Migrate ESLint linting from CodeClimate to CircleCI#3923
Merged
Conversation
**Why**: CircleCI should report the results of linting as test output, as a substitute for CodeClimate, and to ensure that static analysis remains in place for quality code.
**Why**: CodeClimate does not appear to respect local ESLint configuration in all cases, causing many false negatives and false positives.
zachmargolis
approved these changes
Jul 15, 2020
**Why**: Split out lint tasks for better discoverability, and quicker execution
jmhooper
approved these changes
Jul 15, 2020
Contributor
jmhooper
left a comment
jmhooper
left a comment
There was a problem hiding this comment.
The is 💯, thanks Andrew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #3909 (comment), #3914
Why: CodeClimate does not appear to respect local ESLint configuration in all cases, causing many false negatives and false positives.
These changes propose to remove ESLint testing from CodeClimate, running them instead as part of the existing CircleCI test step.
To Do: