Merged
Conversation
**Why**: The event property `event` was set to `visit`, which is wrong. This particular event corresponds to the user clicking a link in their email to cancel the account deletion request. This only validates the token, and if the token is valid, it displays a page where the user can click a button to process the cancellation.
Update Account Reset Cancel analytics
**Why**: To make it easier to query how many users have completed MFA Setup. Currently, MFA setup is tracked in 4 different events. **How**: Use the same event for all MFA setup scenarios, and add a `multi_factor_auth_method` property to differentiate between them.
LG-802 Unify MFA setup events
**Why**: To big up bug fixes in the latest patch version
**Why**: A user could delete their TOTP or PIV/CAC if it was their last MFA method, meaning they had to start their MFA setup again. This commit fixes that by checking that the user has multiple MFA methods before displaying the disable button for those and checking that they aren't the last MFA method before disabling them.
**Why**: #2622 namespaced the API we used to communicate to analytics wether platform authenticators were supported. That commit supported the old API to allow new and old servers to run alongside each other. This commit tears down that API.
**Why**: Through the Devise gem, the DB already captures the info listed below. Displaying it to the user is a trivial change, and makes it easier for the user and for the customer contact center folks to verify the validity of claims such as "I've been hacked".
**Why**: To be more granular in how we offer piv cac to agencies. **How**: Add piv_cac and piv_cac_scoped_by_email to the service_provider model. Update PivCacService with a piv_cac_available_for_sp? method.
**Why**: The `geo_data` folder gets created every time the setup script runs. This commit changes the script to use to `-p` option with `mkdir` so that the script does not fail if the `geo_data` folder exists.
**Why**: To use the latest and greatest and because this is the version the CircleCI container we are using has pre-installed
**Why**: The name of the geolite db file changes occasionally. This commit uses a glob to get the latest version of the file and copy that.
**Why**: To make the style more consistent with the rest of the site and move away from modal popups. **How**: Create new routes for user registration cancellation. Update the cancel partial that triggered the javascript popup and replace the links to point to the new page. Add a new tracking event.
**Why**: The latest CircleCI image is running Node v10, but our IdP servers are running v8. This change allows CI to work w/ v8 while we upgrade the IdP servers to v10.
jmhooper
approved these changes
Dec 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.