Skip to content

Downgrade to node v8 and ignore engines on install#2680

Merged
jmhooper merged 3 commits intomasterfrom
jmhooper-downgrade-to-node-8
Dec 3, 2018
Merged

Downgrade to node v8 and ignore engines on install#2680
jmhooper merged 3 commits intomasterfrom
jmhooper-downgrade-to-node-8

Conversation

@jmhooper
Copy link
Contributor

@jmhooper jmhooper commented Dec 3, 2018

Why: The latest CircleCI image is running Node v10, but our IdP
servers are running v8. This change allows CI to work w/ v8 while we
upgrade the IdP servers to v10.

**Why**: The latest CircleCI image is running Node v10, but our IdP
servers are running v8. This change allows CI to work w/ v8 while we
upgrade the IdP servers to v10.
Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmhooper jmhooper merged commit 798741b into master Dec 3, 2018
@jmhooper jmhooper deleted the jmhooper-downgrade-to-node-8 branch February 15, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants