Namespace platform authenticator params in analytics controller#2622
Merged
Namespace platform authenticator params in analytics controller#2622
Conversation
**Why**: The analytics controller is meant to function as an general controller for capture anayltics for the frontend. Prior to this commit it was primarily handling the platform authenticator analytics event. **How**: This commit makes the controller more general so that it communicates that it should be built out to handle more events and moves the platform auth event into a namespace so that the API can be extended to include more events. Additionally, care was given to make sure that the current implementation is supported so that we don't drop events while running instances running this code alongside instances running the new code.
12 tasks
stevegsa
reviewed
Oct 24, 2018
stevegsa
reviewed
Oct 24, 2018
| @@ -0,0 +1,20 @@ | |||
| module RequestHelper | |||
Contributor
There was a problem hiding this comment.
Are these changes just piggybacking on this PR?
Contributor
Author
There was a problem hiding this comment.
Yeah, I added a helper to authenticate a user in the specs. The analytics request specs require you be authed.
jmhooper
added a commit
that referenced
this pull request
Oct 24, 2018
**Why**: #2622 namespaced the API we used to communicate to analytics wether platform authenticators were supported. That commit supported the old API to allow new and old servers to run alongside each other. This commit tears down that API.
jmhooper
added a commit
that referenced
this pull request
Nov 26, 2018
**Why**: #2622 namespaced the API we used to communicate to analytics wether platform authenticators were supported. That commit supported the old API to allow new and old servers to run alongside each other. This commit tears down that API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The analytics controller is meant to function as an general
controller for capture analytics for the frontend. Prior to this commit
it was primarily handling the platform authenticator analytics event.
How: This commit makes the controller more general so that it communicates
that it should be built out to handle more events and moves the platform
auth event into a namespace so that the API can be extended to include
more events. Additionally, care was given to make sure that the current
implementation is supported so that we don't drop events while running
instances running this code alongside instances running the new code.
Controllers
authenticated, make sure to add
before_action :confirm_two_factor_authenticatedas the first callback.
Database
Unsafe migrations are implemented over several PRs and over several
deploys to avoid production errors. The strong_migrations gem
will warn you about unsafe migrations and has great step-by-step instructions
for various scenarios.
Indexes were added if necessary. This article provides a good overview
of indexes in Rails.
Verified that the changes don't affect other apps (such as the dashboard)
When relevant, a rake task is created to populate the necessary DB columns
in the various environments right before deploying, taking into account the users
who might not have interacted with this column yet (such as users who have not
set a password yet)
Migrations against existing tables have been tested against a copy of the
production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
issues. In that case, all the migration did was add a new column and an index to
the Users table, which might seem innocuous.
Encryption
Routes
state or result in destructive behavior).
Session
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
Testing
and invalid inputs.