Merged
Conversation
* Validate SAML configuration during application start changelog: Internal, SAML, Validate SAML configuration during application start * add specs
* Allow approving pending IPP enrollments in int Currently, when testing the IPP flow in the sandbox (int), one must wait 1 to 2 hours before the verification is complete. The sandbox is the environment that all our partners use to test their apps, and that the Partnerships team uses to test, and for live demos for partners. Having to wait 1 to 2 hours is a huge blocker. A few months ago, a feature was built that allows approving pending IPP enrollments immediately via the /test/ipp route. This feature was originally built for local development only. This PR seeks to make this feature available in our deployed hosts as well, via a config setting. In the process, I made some improvements to the existing feature, such as: - Add controller and feature tests - Move the logic that determines whether or not this feature is available to `FeatureManagement` - Make sure the user is fully authenticated - When not in local development, only display and update pending enrollments that belong to the current user - Make queries more robust and performant with `find_by` and avoiding N+1 queries - In the view, use `size` instead of `count`, since `count` can lead to some issues in some cases (although unlikely in this situation). changelog: Internal, IPP testing, Allow immediate approval of pending IPP enrollments in int (LG-16017)
* changelog: Upcoming Features, Attempts API, Some enrollment events
* changelog: Upcoming Feature, Attempts API, Add events and failure reason handling
* changelog: Upcoming Features, passport, fill in id type on choose id type screen if already selected * Fixing controller spec * Updating spec * Updated naming convention for passport not selected status * Updating feature test for standard and mobile flow * changing radio check name in feature spec * Updating standard flow and adding hybrid tests
changelog: Internal, Maintenance, Delete completed Profile backfill classes
changelog: Bug Fixes, Authorization Requests, Fix default AAL overriding specified AAL value
… how verify identiy works page (#12046)
* changelog: Internal, Tech debt, Remove unused phone confirmation database fields * updated schema * mark phone cofirmed as true * mark phone confirmed as true in spec * remove changes to phone_configuration.confirmed_at
…2037) changelog: Internal, In-person Proofing, Update the status_check_completed_at enrollment timestamp when an enrollment is skipped during the get_usps_proofing_results_job This commit also enhances the enrollment_skipped event by adding the response from the USPS API to the event log.
jmdembe
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features