LG-15945 Update status_check_completed_at for skipped enrollments#12037
Merged
shanechesnutt-ft merged 1 commit intomainfrom Apr 2, 2025
Merged
LG-15945 Update status_check_completed_at for skipped enrollments#12037shanechesnutt-ft merged 1 commit intomainfrom
shanechesnutt-ft merged 1 commit intomainfrom
Conversation
shanechesnutt-ft
force-pushed
the
sc/LG-15945
branch
from
4a85272 to
feab5cb
Compare
shanechesnutt-ft
force-pushed
the
sc/LG-15945
branch
2 times, most recently
from
abea53e to
cb42b65
Compare
eileen-nava
approved these changes
Apr 2, 2025
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
This looks good and worked as expected. Approved!
Contributor
There was a problem hiding this comment.
As we discussed on our call, I support deleting this context block. Having a context block for profiles that had the deactivation reason "password_reset" and a context block for enrollments with the status "password_reset" did not add value.
eileen-nava
approved these changes
Apr 2, 2025
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
I reviewed the latest commit. Approved!
changelog: Internal, In-person Proofing, Update the status_check_completed_at enrollment timestamp when an enrollment is skipped during the get_usps_proofing_results_job This commit also enhances the enrollment_skipped event by adding the response from the USPS API to the event log.
shanechesnutt-ft
force-pushed
the
sc/LG-15945
branch
from
4a4df85 to
1f9623f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15945
🛠 Summary of changes
get_usps_proofing_results_job📜 Testing Plan
status_check_compelted_attimestamp is updated to current time