LG-12304 Remove unused phone confirmation data (2 of 2)

[kevinsmaster5]

🎫 Ticket

Link to the relevant ticket:
LG-12304

For 50/50 state expands previous pr #12012

[kevinsmaster5]

@vrajmohan should I move this change to Part 1 #12012 I'm looking at how you're conducting a similar ticket.

[kevinsmaster5]

Then I think it gets removed with this PR if I'm understanding the order of operations.

[vrajmohan]

I adapted https://handbook.login.gov/articles/manage-50-50-state.html#database-changes

[vrajmohan]

LGTM

[kevinsmaster5]

@vrajmohan This was causing errors due to confirmed_at no longer being available here. I'm thinking I should split this and the test changes off into another pull, then make the DB changes in p3. Does that sound right?

[vrajmohan]

I'm confused - why did we not ignore confirmed_at (ie add it to self.ignored_columns) in the previous commit?

[vrajmohan]

In the previous PR, it looks to me that we should not have this change - https://github.com/18F/identity-idp/pull/12012/files#diff-8d5f3716bccf71cc2343f6bc0ecb89eb3bba3d31ad84438ed3343caa4e8589b7L33?

[kevinsmaster5]

I'm confused - why did we not ignore confirmed_at (ie add it to self.ignored_columns) in the previous commit?

You are correct on both counts.
I have an amended PR to remedy what I needed in that PR
#12029

[kevinsmaster5]

@vrajmohan nothing much has changed since you reviewed but thought I'd give you a nudge before merging later today.