Skip to content

Improve test reliability by adding page assertions in feature test helpers #12016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Mar 31, 2025
Merged

Improve test reliability by adding page assertions in feature test helpers #12016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spec/features/idv/doc_auth/how_to_verify_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
facial_match_required: facial_match_required }
)
sign_in_via_branded_page(user)
expect(page).to have_current_path(idv_welcome_path)
complete_doc_auth_steps_before_agreement_step
complete_agreement_step
end
Expand Down
2 changes: 2 additions & 0 deletions spec/support/features/session_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,9 @@ def skip_second_mfa_prompt
end

def sign_in_via_branded_page(user)
expect(page).to have_current_path new_user_session_path
fill_in_credentials_and_submit(user.last_sign_in_email_address.email, user.password)
expect(page).to have_current_path(login_two_factor_path(otp_delivery_preference: 'sms'))
fill_in_code_with_last_phone_otp
click_submit_default
end
Expand Down