Skip to content

LG-12304 Remove unused phone confirmation data (2 of 2) #12013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinsmaster5 merged 5 commits into from
Apr 2, 2025
Merged

LG-12304 Remove unused phone confirmation data (2 of 2) #12013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd78f78
changelog: Internal, Tech debt, Remove unused phone confirmation data…
kevinsmaster5 Mar 21, 2025
af01b22
updated schema
kevinsmaster5 Mar 24, 2025
b22a2d7
mark phone cofirmed as true
kevinsmaster5 Mar 26, 2025
1d73339
mark phone confirmed as true in spec
kevinsmaster5 Mar 26, 2025
e11b62d
remove changes to phone_configuration.confirmed_at
kevinsmaster5 Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/models/phone_configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

class PhoneConfiguration < ApplicationRecord
self.ignored_columns += %w[confirmation_sent_at]
include EncryptableAttribute

belongs_to :user, inverse_of: :phone_configurations
Expand Down
1 change: 0 additions & 1 deletion app/models/user.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

class User < ApplicationRecord
self.ignored_columns += %w[phone_confirmed_at]
include NonNullUuid

include ActionView::Helpers::DateHelper
Expand Down
5 changes: 5 additions & 0 deletions db/primary_migrate/20250321182247_remove_phone_confirmed_at_from_users.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class RemovePhoneConfirmedAtFromUsers < ActiveRecord::Migration[8.0]
def change
safety_assured { remove_column :users, :phone_confirmed_at, :datetime }
end
end
5 changes: 5 additions & 0 deletions db/primary_migrate/20250321182616_remove_phone_confirmation_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class RemovePhoneConfirmationConfig < ActiveRecord::Migration[8.0]
def change
safety_assured { remove_column :phone_configurations, :confirmation_sent_at, :datetime }
end
end
2 changes: 0 additions & 2 deletions db/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,6 @@
t.text "encrypted_phone", null: false, comment: "sensitive=true"
t.integer "delivery_preference", default: 0, null: false, comment: "sensitive=false"
t.boolean "mfa_enabled", default: true, null: false, comment: "sensitive=false"
t.datetime "confirmation_sent_at", precision: nil, comment: "sensitive=false"
t.datetime "confirmed_at", precision: nil, comment: "sensitive=false"
t.datetime "created_at", precision: nil, null: false, comment: "sensitive=false"
t.datetime "updated_at", precision: nil, null: false, comment: "sensitive=false"
Expand Down Expand Up @@ -623,7 +622,6 @@
t.integer "second_factor_attempts_count", default: 0, comment: "sensitive=false"
t.string "uuid", limit: 255, null: false, comment: "sensitive=false"
t.datetime "second_factor_locked_at", precision: nil, comment: "sensitive=false"
t.datetime "phone_confirmed_at", precision: nil, comment: "sensitive=false"
t.string "direct_otp", comment: "sensitive=true"
t.datetime "direct_otp_sent_at", precision: nil, comment: "sensitive=false"
t.string "unique_session_id", comment: "sensitive=false"
Expand Down