Conversation
…ley/lg-10681-remove-arcgis-usage
spec/features/idv/in_person_spec.rb
Outdated
|
|
||
| # location page | ||
| complete_location_step | ||
| complete_full_address_location_step |
There was a problem hiding this comment.
now, the "full address" location step is our only location step, right? Should we rename the helper methods and keep these specs otherwise unchanged?
| post '/api/service_provider' => 'service_provider#update' | ||
| post '/api/verify/images' => 'idv/image_uploads#create' | ||
| post '/api/logger' => 'frontend_log#create' | ||
| post '/api/addresses' => 'idv/in_person/address_search#index' |
There was a problem hiding this comment.
There's still a couple lingering references to this path. Do they need to be cleaned up?
There was a problem hiding this comment.
Since the AC said to leave this React component in place, I judged this update to be out-of-scope.
There was a problem hiding this comment.
Yeah the idea is that this'll be ready to use again once we implement the AWS-based geocoding service... since it's not being used in prod anymore it should be okay. But it's a little risky if that flag gets switched accidentally.
There was a problem hiding this comment.
Personally I'd rather us having removed the unused code and rely on git history if/when we need it in the future, since requirements change and we otherwise have no obligation to clean this up.
| get '/api/openid_connect/userinfo' => 'openid_connect/user_info#show' | ||
| post '/api/risc/security_events' => 'risc/security_events#create' | ||
|
|
||
| post '/api/address_search' => 'idv/in_person/public/address_search#index' |
There was a problem hiding this comment.
@soniaconnolly 's comment at #9136 (comment) reminded me here, is the removal of these paths going to cause some issues during deployment for users running JavaScript served by old boxes sending requests to new servers? Or is this already disabled in production?
There was a problem hiding this comment.
No, the current status of the in_person_full_address_entry_enabled ensures that users will not be using this endpoint in production.
4 participants
🎫 Ticket
🛠 Summary of changes
in_person_full_address_entry_enabledfeature flag📜 Testing Plan
Provide a checklist of steps to confirm the changes.