Skip to content

LG-15237 Allow the SP return URL resolver to interpolate locale values into URLs #11620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 2 commits into from
Dec 12, 2024
Merged

LG-15237 Allow the SP return URL resolver to interpolate locale values into URLs #11620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
652f76e
LG-15237 Allow the SP return URL resolver to interpolate locale value…
jmhooper Dec 11, 2024
6a334d6
Update app/services/sp_return_url_resolver.rb
jmhooper Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/services/sp_return_url_resolver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ def homepage_url
end

def post_idv_follow_up_url
service_provider.post_idv_follow_up_url || homepage_url
url = service_provider.post_idv_follow_up_url || homepage_url
return if url.blank?
format(url.to_s, locale: I18n.locale.to_s)
end

private
Expand Down
8 changes: 8 additions & 0 deletions spec/services/sp_return_url_resolver_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,5 +170,13 @@

it { expect(post_idv_follow_up_url).to eq(sp_post_idv_follow_up_url) }
end

context 'with a template param in the URL' do
let(:sp_post_idv_follow_up_url) { 'https://sp.gov/follow_up?locale=%{locale}' }

it 'interpolates the appropriate value' do
expect(post_idv_follow_up_url).to eq('https://sp.gov/follow_up?locale=en')
end
end
end
end