LG-14912 Confirming new email from consent screen in different session doesn't lead to partner#11439
Merged
kevinsmaster5 merged 15 commits intomainfrom Nov 8, 2024
Conversation
aduth
reviewed
Nov 1, 2024
aduth
reviewed
Nov 4, 2024
aduth
reviewed
Nov 4, 2024
kevinsmaster5
commented
Nov 5, 2024
kevinsmaster5
force-pushed
the
kmas-lg-14912-confirming-new-email-consent-session
branch
2 times, most recently
from
a74a86d to
604745d
Compare
aduth
reviewed
Nov 7, 2024
…ads to partner sign-in
…in UserMailerPreview
… emails controller
kevinsmaster5
force-pushed
the
kmas-lg-14912-confirming-new-email-consent-session
branch
from
c9b3bff to
e0b429d
Compare
kevinsmaster5
deleted the
kmas-lg-14912-confirming-new-email-consent-session
branch
This was referenced Nov 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-14912
🛠 Summary of changes
Bug identified while testing #11415 indicates awkward user experience in the event of switching browsers/devices or session time out.
These changes make the previous PR redundant.
📜 Testing Plan
Alternatively, for #3 copy and paste the confirmation link into a private browser window and observe that logging in returns you to the confirmation flow.