LG 14404 Add email at confirmation to share with service provider

[kevinsmaster5]

🎫 Ticket

Link to the relevant ticket:
LG-14404

🛠 Summary of changes

Remedies the user flow from adding a new email address at Service Provider linking confirmation.

Expected behavior:
Clicking the link that appears in the added email address confirmation email message should return you to where you left off from selecting an email to pass over to the SP

Actual behavior:
You end up at the account dashboard and have to click the Return to SP link to get back on track.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Using a simulated SP such as SAML or OIDC log in with an account that hasn't been connected yet.
• Proceed to the flow and choose to add a new email
• Observe that by clicking the confirmation link you are returned to where you can select that email and proceed on to the service provider.

👀 Screenshots

email-change-redirect.mov

[aduth]

Can you explain what this code is for?

[kevinsmaster5]

It sets a session value that will help determine the redirect in the email confirmations controller

identity-idp/app/controllers/users/email_confirmations_controller.rb

Lines 47 to 51 in f940e20

	if user_session[:pending_completions_consent] == true
	redirect_to sign_up_select_email_url
	else
	redirect_to account_url
	end

it will be deleted in the completions controller when they get redirected finally to the SP

identity-idp/app/controllers/sign_up/completions_controller.rb

Line 31 in f940e20

user_session.delete(:pending_completions_consent)

[aduth]

@kevinsmaster5 Do we still need this pull request, or did #11439 replace it?

[kevinsmaster5]

@kevinsmaster5 Do we still need this pull request, or did #11439 replace it?

We do not. I'll close it now.