ProgressiveProofer refactor 4/N: InstantVerify state id address#11434
Merged
ProgressiveProofer refactor 4/N: InstantVerify state id address#11434
Conversation
jmhooper
approved these changes
Nov 1, 2024
matthinz
force-pushed
the
matthinz/prog-proofer-refactor-03-iv-residential
branch
2 times, most recently
from
4baa6b3 to
855dd7c
Compare
Base automatically changed from
matthinz/prog-proofer-refactor-03-iv-residential
to
main
November 4, 2024 22:45
matthinz
force-pushed
the
matthinz/prog-proofer-refactor-04-iv-id
branch
from
a87210c to
e52ae22
Compare
Add plugin to do IV calls for state ID addresses, along with a spec covering its usage [skip changelog]
matthinz
force-pushed
the
matthinz/prog-proofer-refactor-04-iv-id
branch
from
e52ae22 to
2cebf57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Continuing the work in #11420, #11427, and #11433 this PR extracts
proof_id_address_with_lexis_nexis_if_neededintoInstantVerifyStateIdAddressPlugin. It then adds a spec for the plugin covering the following use cases:It then cleans up some tests in the
ProgressiveProoferspec that are now covered by individual plugin specs.📜 Testing Plan
Provide a checklist of steps to confirm the changes.