ProgressiveProofer refactor 2/N: AAMVA#11427
Conversation
There was a problem hiding this comment.
Note that in the IPP + different addresses case, if the residential address failed verification, then instant_verify_result will have success: false and vendor_name: ResolutionCannotPass, so no AAMVA call will be made.
856bb84 to
9e310dc
Compare
n1zyy
left a comment
There was a problem hiding this comment.
I have not run through the checklist you provided, and someone should before merging. But I spent a while working through the code and it looks solid.
There was a problem hiding this comment.
❤️ for this descriptive name -- it makes perfectly clear why we go from "but the failure can possibly be covered by AAMVA" to "does not make an AAMVA call"
Add a new resolution plugin for AAMVA and call it from the ProgressiveProofer. [skip changelog]
And add a spec for it
9e310dc to
2507939
Compare
gina-yamada
left a comment
There was a problem hiding this comment.
Logic for existing code and new plugin remains the same. I manually tested IPP with AAMVA approved jurisdictions (CO) and not approved (CA) and get the outcome I'd expect. (For both cases; same address as ID, diff address as ID.)
🛠 Summary of changes
Continuing the work in #11420, this PR extracts
proof_id_with_aamva_if_neededintoAamvaPlugin. It then adds a spec for the plugin covering the following use cases:📜 Testing Plan
Provide a checklist of steps to confirm the changes.