LG-14525: threatmetrix api account creation#11340
Conversation
…-api-account-creation
…count' into LG-14525-threatmetrix-api-account-creation
…-api-account-creation
…-api-account-creation
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Submitting my review as incomplete since I ran out of time to finish reviewing. At first glance, doesn't look like there's any big blockers.
There was a problem hiding this comment.
I like this revised direction a lot better 👍
config/application.yml.default
Outdated
| ################################################################### | ||
| # LexisNexis DDP/ThreatMetrix ##################################### |
There was a problem hiding this comment.
I see why we moved since this file is alphabetized, but now the groupings are a little weird because e.g. lexisnexis_instant_verify_timeout is no longer under the "Instant Verify and Phone Finder Integrations" block.
I'd suggest either:
- Get rid of the comment blocks
- Rename the new configuration so that it's alphabetized with other ThreatMetrix keys, e.g.
lexisnexis_threatmetrix_authentication_policy
There was a problem hiding this comment.
Now that we've renamed the configuration, can you move the comment block back to where it was?
|
How do I test this? |
I updated the test plan to be clearer. It should log in analytics events for now since we dont expect to do anything yet. |
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
A few minor comments, but LGTM otherwise 👍 Tested locally and worked as expected.
config/application.yml.default
Outdated
| ################################################################### | ||
| # LexisNexis DDP/ThreatMetrix ##################################### |
There was a problem hiding this comment.
Now that we've renamed the configuration, can you move the comment block back to where it was?
4 participants
🎫 Ticket
Link to the relevant ticket:
LG-14525
🛠 Summary of changes
This implements the API call to the Threatmetrix DDP call. Under a feature toggle, will call account creation API call when user lands on completions controller during account creation.
📜 Testing Plan
To test
Configs Needed
Ensure
lexisnexis_threatmetrix_authentication_policyhas a policy name allowed.Turn on Feature toggle by putting
account_creation_device_profiling_collecting_enabledto set tocollect_onlyAfterwards, go through Account Creation process while tracking login events.
Verify that User goes through account creation without issue.
Also verify that analytics logs
account_creation_tmx_resultas a pass event. (Currently not set up to fail unless missing values like threat metrix session id etc.