LG-14382: Update intl-tel-input to the latest version#11257
Merged
Conversation
aduth
commented
Sep 18, 2024
Contributor
Author
There was a problem hiding this comment.
This change is made because intl-tel-input no longer assigns a global intlTelInputUtils, and E.164 is the default (source).
changelog: Internal, Dependencies, Update dependency to latest version
aduth
force-pushed
the
aduth-lg-14382-intl-tel-input
branch
from
70c14d7 to
842af74
Compare
zachmargolis
approved these changes
Sep 18, 2024
Now handled internally in intl-tel-input with a11y-text element. Test coverage already exists here for expected value (see modification)
Removed upstream in jackocnr/intl-tel-input#1421
Latest version has "countryOrder" rather than "preferredCountries", no longer outputs duplicate iitems
AShukla-GSA
pushed a commit
that referenced
this pull request
Sep 30, 2024
* LG-14382: Update intl-tel-input to latest version changelog: Internal, Dependencies, Update dependency to latest version * Remove unnecessary screen reader text assignment Now handled internally in intl-tel-input with a11y-text element. Test coverage already exists here for expected value (see modification) * Remove unnecessary aria-owns removal Removed upstream in jackocnr/intl-tel-input#1421 * Use i18n option to customize aria-label Available as of jackocnr/intl-tel-input@fc0fc06 * Remove unnecessary duplicate removal logic Latest version has "countryOrder" rather than "preferredCountries", no longer outputs duplicate iitems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-14382
🛠 Summary of changes
Updates
intl-tel-inputto the latest version, from 17.0.19 to 24.5.0.Release notes: https://github.com/jackocnr/intl-tel-input/releases
This is a significant upgrade spanning multiple major versions, and had more than a handful of breaking changes to sift through.
While it's a maintenance task, it's also partly motivated by discovery in #11189 that the phone input had accessibility issues uncovered by the changes there. Newer versions of the library address those issues.
There's also at least one noteworthy feature included in newer versions: the ability to search for countries in the dropdown.
Draft: Working to resolve an issue with "Single Country Selection" (not currently used in the application).
📜 Testing Plan
Verify there's no regression in behavior of the phone input
You might also want to check other usage in the application for regressions:
👀 Screenshots