Run all relevant Axe accessibility test groups#11189
Merged
Conversation
changelog: Internal, Accessibility Tests, Run Axe scan against all WCAG 2.0-2.2 A & AA
mitchellhenke
approved these changes
Sep 3, 2024
aduth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes an issue with our accessibility page testing where applying
:wcag22aaruns only tests for rules specific to WCAG 2.2 AA, and does not inherit from rules below that.I noticed this when trying to fix an existing issue which hadn't been flagged by the tests. I'll plan to open a separate pull request for that, since it involves writing new tests, but the scope of this pull request is addressing existing issues within the current tests.
There are existing issues with the phone input component. These are addressed in newer versions of the library, and while I have an in-progress branch to implement the upgrade, there are some incompatibilities with the newer version and content security policies (see upstream pull request jackocnr/intl-tel-input#1778 ). Instead, the changes here exempt those violations and a corresponding ticket for upgrade is tracked at LG-14382.
📜 Testing Plan
Verify build passes.