1415 and 1419 screen reader enhancements#1421
Merged
jackocnr merged 3 commits intojackocnr:masterfrom May 21, 2023
Merged
Conversation
Owner
|
Thanks so much for putting this together @danman01. My only feedback is that when separateDialCode is disabled, we still want to include the dial code in the title. |
added 2 commits
May 11, 2023 15:47
- when separateDialCode is enabled, removes dial code from title closes jackocnr#1415
danman01
force-pushed
the
fixes/1415-screen-reader-duplicates-country-code
branch
from
b62aaa3 to
fa5e32c
Compare
Contributor
Author
|
@jackocnr Updated! Let me know if you think the specs are in the right place? After working on it, it looks like the "Unknown" title scenario won't ever get hit, but there might be some case where we still need it in there. |
Owner
|
This looks really great, thank you! Any chance you could build the JS as well? Then we can merge. |
Contributor
Author
|
@jackocnr I ran the build js command and committed the results |
Owner
|
Thanks again |
aduth
added a commit
to 18F/identity-idp
that referenced
this pull request
Sep 19, 2024
Removed upstream in jackocnr/intl-tel-input#1421
aduth
added a commit
to 18F/identity-idp
that referenced
this pull request
Sep 19, 2024
* LG-14382: Update intl-tel-input to latest version changelog: Internal, Dependencies, Update dependency to latest version * Remove unnecessary screen reader text assignment Now handled internally in intl-tel-input with a11y-text element. Test coverage already exists here for expected value (see modification) * Remove unnecessary aria-owns removal Removed upstream in jackocnr/intl-tel-input#1421 * Use i18n option to customize aria-label Available as of jackocnr/intl-tel-input@fc0fc06 * Remove unnecessary duplicate removal logic Latest version has "countryOrder" rather than "preferredCountries", no longer outputs duplicate iitems
AShukla-GSA
pushed a commit
to 18F/identity-idp
that referenced
this pull request
Sep 30, 2024
* LG-14382: Update intl-tel-input to latest version changelog: Internal, Dependencies, Update dependency to latest version * Remove unnecessary screen reader text assignment Now handled internally in intl-tel-input with a11y-text element. Test coverage already exists here for expected value (see modification) * Remove unnecessary aria-owns removal Removed upstream in jackocnr/intl-tel-input#1421 * Use i18n option to customize aria-label Available as of jackocnr/intl-tel-input@fc0fc06 * Remove unnecessary duplicate removal logic Latest version has "countryOrder" rather than "preferredCountries", no longer outputs duplicate iitems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1419 - fixes screen reader not reading select box option
closes #1419
1415: remove duplicate country code from screen reader
closes #1415