Skip to content

LG-12377 Remove 404 action for State ID Controller/FSM removal #11243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jennyverdeyen merged 2 commits into from
Sep 18, 2024
Merged

LG-12377 Remove 404 action for State ID Controller/FSM removal #11243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cf9c7d
LG-12377 Remove 404 action for State ID Controller/FSM removal
jennyverdeyen Sep 16, 2024
8433aaf
update 50/50 test
jennyverdeyen Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions app/controllers/idv/in_person/state_id_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ class StateIdController < ApplicationController
include Idv::AvailabilityConcern
include IdvStepConcern

before_action :render_404_if_controller_not_enabled
before_action :redirect_unless_enrollment # confirm previous step is complete
before_action :set_usps_form_presenter

Expand Down Expand Up @@ -92,11 +91,6 @@ def self.step_info

private

def render_404_if_controller_not_enabled
render_not_found unless
IdentityConfig.store.in_person_state_id_controller_enabled
end

def redirect_unless_enrollment
redirect_to idv_document_capture_url unless current_user.establishing_in_person_enrollment
end
Expand Down
26 changes: 0 additions & 26 deletions spec/controllers/idv/in_person/state_id_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,32 +28,6 @@
)
end

context '#render_404_if_controller_not_enabled' do
context 'flag not set' do
before do
allow(IdentityConfig.store).to receive(:in_person_state_id_controller_enabled).
and_return(nil)
end
it 'renders a 404' do
get :show

expect(response).to be_not_found
end
end

context 'flag not enabled' do
before do
allow(IdentityConfig.store).to receive(:in_person_state_id_controller_enabled).
and_return(false)
end
it 'renders a 404' do
get :show

expect(response).to be_not_found
end
end
end

context '#confirm_establishing_enrollment' do
let(:enrollment) { nil }
it 'redirects to document capture if not complete' do
Expand Down
7 changes: 2 additions & 5 deletions spec/features/idv/steps/in_person/state_id_50_50_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,8 @@
page.refresh
end

it 'renders the 404 page' do
expect(page).to have_content(
"The page you were looking for doesn’t exist.\nYou might want to double-check your link" \
" and try again. (404)",
)
it 'renders the state ID controller page without error' do
expect(page).to have_current_path(idv_in_person_proofing_state_id_path, wait: 10)
end
end

Expand Down