Skip to content

LG-14153 Display EIPP Expiration Date on Ready to Verify View and Email #11068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gina-yamada merged 8 commits into from
Aug 13, 2024
Merged

LG-14153 Display EIPP Expiration Date on Ready to Verify View and Email #11068

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fc1854f
New config var for EIPP exp date
gina-yamada Aug 12, 2024
5157869
Added config var for eipp exp date
gina-yamada Aug 12, 2024
b9a5fe9
Display 7 day exp date if EIPP for enrollments
gina-yamada Aug 12, 2024
1fbb1eb
Use if/else rather than terinary
gina-yamada Aug 12, 2024
8147140
Added eipp spec for date_date days
gina-yamada Aug 12, 2024
b74a012
Fix linter error
gina-yamada Aug 12, 2024
2e68ae5
changelog: User-Facing Improvements, Enhanced In-person proofing, Add…
gina-yamada Aug 12, 2024
e387056
Merge branch 'main' of github.com:18F/identity-idp into yamada/lg-141…
gina-yamada Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/models/in_person_enrollment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def minutes_since_last_status_update

def due_date
start_date = enrollment_established_at.presence || created_at
start_date + IdentityConfig.store.in_person_enrollment_validity_in_days.days
start_date + days_to_expire
end

def days_to_due_date
Expand All @@ -157,6 +157,10 @@ def enhanced_ipp?

private

def days_to_expire
enhanced_ipp? ? IdentityConfig.store.in_person_eipp_enrollment_validity_in_days.days : IdentityConfig.store.in_person_enrollment_validity_in_days.days
Comment thread
aduth marked this conversation as resolved.
Outdated
end

def on_notification_sent_at_updated
change_will_be_saved = notification_sent_at_change_to_be_saved&.last.present?
if change_will_be_saved && notification_phone_configuration.present?
Expand Down
1 change: 1 addition & 0 deletions config/application.yml.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ idv_send_link_max_attempts: 5
idv_sp_required: false
in_person_completion_survey_url: 'https://login.gov'
in_person_doc_auth_button_enabled: true
in_person_eipp_enrollment_validity_in_days: 7
in_person_email_reminder_early_benchmark_in_days: 11
in_person_email_reminder_final_benchmark_in_days: 1
in_person_email_reminder_late_benchmark_in_days: 4
Expand Down
1 change: 1 addition & 0 deletions lib/identity_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ def self.store
config.add(:idv_sp_required, type: :boolean)
config.add(:in_person_completion_survey_url, type: :string)
config.add(:in_person_doc_auth_button_enabled, type: :boolean)
config.add(:in_person_eipp_enrollment_validity_in_days, type: :integer)
config.add(:in_person_email_reminder_early_benchmark_in_days, type: :integer)
config.add(:in_person_email_reminder_final_benchmark_in_days, type: :integer)
config.add(:in_person_email_reminder_late_benchmark_in_days, type: :integer)
Expand Down