Skip to content

Remove tests and logging related to IRS reproofing #11055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Aug 9, 2024
Merged

Remove tests and logging related to IRS reproofing #11055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions app/services/analytics_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,7 +1374,6 @@ def idv_doc_auth_submitted_pii_validation(
# @param analytics_id [String] "Doc Auth" for remote unsupervised, "In Person Proofing" for IPP
# @param errors [Hash] Details about vendor-specific errors encountered during the stages of the identity resolution process
# @param flow_path [String] "hybrid" for hybrid handoff, "standard" otherwise
# @param irs_reproofing [Boolean] Whether the user is being forced to reproof to access the IRS
Copy link
Copy Markdown
Contributor

@n1zyy n1zyy Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was from back in the Team Agnes Attempts API days. Most of that code has already been ripped out; this one must have escaped notice.

# @param lexisnexis_instant_verify_workflow_ab_test_bucket [String] A/B test bucket for Lexis Nexis InstantVerify workflow testing
# @param opted_in_to_in_person_proofing [Boolean] Whether this user explicitly opted into in-person proofing
# @param proofing_results [Hash]
Expand Down Expand Up @@ -1440,7 +1439,6 @@ def idv_doc_auth_verify_proofing_results(
analytics_id: nil,
errors: nil,
flow_path: nil,
irs_reproofing: nil,
lexisnexis_instant_verify_workflow_ab_test_bucket: nil,
opted_in_to_in_person_proofing: nil,
proofing_results: nil,
Expand All @@ -1460,7 +1458,6 @@ def idv_doc_auth_verify_proofing_results(
analytics_id:,
errors:,
flow_path:,
irs_reproofing:,
lexisnexis_instant_verify_workflow_ab_test_bucket:,
opted_in_to_in_person_proofing:,
proofing_results:,
Expand Down
57 changes: 0 additions & 57 deletions spec/controllers/sign_up/completions_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,62 +387,5 @@
end
end
end

context 'when the user goes through reproofing' do
let!(:user) { create(:user, profiles: [create(:profile, :active)]) }

xit 'does not log a reproofing event during initial proofing' do
stub_sign_in(user)
subject.session[:sp] = {
issuer: 'foo',
request_url: 'http://example.com',
acr_values: Saml::Idp::Constants::IAL1_AUTHN_CONTEXT_CLASSREF,
}
patch :update
end

it 'logs a reproofing event upon reproofing' do
original_profile = user.profiles.first
additional_profile = create(:profile, :verified, user: user)

stub_sign_in(user)
subject.session[:sp] = {
issuer: 'foo',
request_url: 'http://example.com',
acr_values: Saml::Idp::Constants::IAL1_AUTHN_CONTEXT_CLASSREF,
}

expect(original_profile.activated_at).to be_present
expect(original_profile.active).to eq true
expect(original_profile.deactivation_reason).to be_nil
expect(original_profile.fraud_review_pending?).to eq(false)
expect(original_profile.gpo_verification_pending_at).to be_nil
expect(original_profile.initiating_service_provider).to be_nil
expect(original_profile.verified_at).to be_present

expect(additional_profile.activated_at).to be_present
expect(additional_profile.active).to eq false
expect(additional_profile.deactivation_reason).to be_nil
expect(additional_profile.fraud_review_pending?).to eq(false)
expect(additional_profile.gpo_verification_pending_at).to be_nil
expect(additional_profile.initiating_service_provider).to be_nil
expect(additional_profile.verified_at).to be_present

patch :update
end

it 'does not log a reproofing event during account redirect' do
user.profiles.create(verified_at: Time.zone.now, active: true, activated_at: Time.zone.now)
stub_sign_in(user)
subject.session[:sp] = {
request_url: 'http://example.com',
acr_values: Saml::Idp::Constants::IAL1_AUTHN_CONTEXT_CLASSREF,
}

patch :update

expect(response).to redirect_to account_path
end
end
end
end