Skip to content

Remove and prevent redundant config#11082

Merged
mitchellhenke merged 4 commits intomainfrom
mitchellhenke/remove-redundant-config
Aug 14, 2024
Merged

Remove and prevent redundant config#11082
mitchellhenke merged 4 commits intomainfrom
mitchellhenke/remove-redundant-config

Conversation

@mitchellhenke
Copy link
Contributor

🛠 Summary of changes

Following some discussion with @matthinz, this PR adds a couple of rules for our default YAML file (with tests):

  1. If a key is defined in the top default section, the key should not be defined again with the same value in dev/test/prod
  2. If a key is defined across dev/test/prod with the same value, it should be moved up into the top default section

@mitchellhenke mitchellhenke requested a review from matthinz August 14, 2024 17:42
@mitchellhenke mitchellhenke marked this pull request as draft August 14, 2024 17:48
Mitchell Henke added 3 commits August 14, 2024 12:57
changelog: Internal, Configuration, Add redundancy checks to YAML configuration file
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/remove-redundant-config branch from 4d564f4 to efda370 Compare August 14, 2024 17:58
@mitchellhenke mitchellhenke marked this pull request as ready for review August 14, 2024 19:43
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/remove-redundant-config branch from 72f5638 to a667911 Compare August 14, 2024 19:44
@mitchellhenke mitchellhenke merged commit 598e7ff into main Aug 14, 2024
@mitchellhenke mitchellhenke deleted the mitchellhenke/remove-redundant-config branch August 14, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants