Skip to content

Fixed broken link to help center. #10968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmax-gsa merged 6 commits into from
Jul 24, 2024
Merged

Fixed broken link to help center. #10968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6bc121e
Fixed broken link to help center.
jmax-gsa Jul 19, 2024
e5f325e
Review comment.
jmax-gsa Jul 19, 2024
eb132f0
Finish cleanup from last change.
jmax-gsa Jul 22, 2024
bf1df2a
More cleanup
jmax-gsa Jul 22, 2024
fb9ee2d
One more loose end
jmax-gsa Jul 22, 2024
7f60af0
Help site specs
jmax-gsa Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...pt/packages/document-capture/components/document-capture-troubleshooting-options.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe('DocumentCaptureTroubleshootingOptions', () => {
'idv.troubleshooting.options.supported_documentslinks.new_tab',
);
expect(links[1].getAttribute('href')).to.equal(
'https://example.com/redirect/?category=verify-your-identity&article=accepted-state-issued-identification&location=document_capture_troubleshooting_options',
'https://example.com/redirect/?category=verify-your-identity&article=accepted-identification-documents&location=document_capture_troubleshooting_options',
);
expect(links[1].target).to.equal('_blank');
});
Expand Down
2 changes: 1 addition & 1 deletion ...ascript/packages/document-capture/components/document-capture-troubleshooting-options.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function DocumentCaptureTroubleshootingOptions({
showDocumentTips && {
url: getHelpCenterURL({
category: 'verify-your-identity',
article: 'accepted-state-issued-identification',
article: 'accepted-identification-documents',
location,
}),
text: t('idv.troubleshooting.options.supported_documents'),
Expand Down
1 change: 0 additions & 1 deletion app/services/marketing_site.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ class UnknownArticleException < StandardError; end
manage-your-account/personal-key
trouble-signing-in/face-or-touch-unlock
verify-your-identity/accepted-identification-documents
verify-your-identity/accepted-state-issued-identification
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we consider adding a redirect in the help center to catch this? or was it never working in the first place

Copy link
Copy Markdown
Contributor

@aduth aduth Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had brought it up in the related Slack discussion and I think we should, but I don't know that that was captured in this ticket. @jmax-gsa do you know if it's going to be addressed here, or is there a separate ticket for it?

Copy link
Copy Markdown
Contributor Author

@jmax-gsa jmax-gsa Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know; I'll bring the question up at standup and either do it as part of this, or drop a pointer to the other ticket if there is one.

Copy link
Copy Markdown
Contributor Author

@jmax-gsa jmax-gsa Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per conversation w/ May during standup, I'll add the redirect. See her comment on the ticket.

Copy link
Copy Markdown
Contributor Author

@jmax-gsa jmax-gsa Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redirecet added in GSA-TTS/identity-site#1305

verify-your-identity/how-to-add-images-of-your-state-issued-id
verify-your-identity/verify-your-identity-in-person
verify-your-identity/phone-number
Expand Down
2 changes: 1 addition & 1 deletion app/views/idv/in_person/state_id.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<%= link_to(
MarketingSite.help_center_article_url(
category: 'verify-your-identity',
article: 'accepted-state-issued-identification',
article: 'accepted-identification-documents',
),
class: 'display-inline',
) do %>
Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/redirect/help_center_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

context 'with valid help center article' do
let(:category) { 'verify-your-identity' }
let(:article) { 'accepted-state-issued-identification' }
let(:article) { 'accepted-identification-documents' }
let(:params) { super().merge(category:, article:) }

it 'redirects to the help center article and logs' do
Expand Down
10 changes: 5 additions & 5 deletions spec/services/marketing_site_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,20 +170,20 @@

context 'with valid article' do
let(:category) { 'verify-your-identity' }
let(:article) { 'accepted-state-issued-identification' }
let(:article) { 'accepted-identification-documents' }

it_behaves_like 'a marketing site URL'

it 'returns article URL' do
expect(url).to eq(
'https://www.login.gov/help/verify-your-identity/accepted-state-issued-identification/',
'https://www.login.gov/help/verify-your-identity/accepted-identification-documents/',
)
end
end

context 'with anchor' do
let(:category) { 'verify-your-identity' }
let(:article) { 'accepted-state-issued-identification' }
let(:article) { 'accepted-identification-documents' }
let(:article_anchor) { 'test-anchor-url' }
let(:url) do
MarketingSite.help_center_article_url(category:, article:, article_anchor:)
Expand All @@ -193,7 +193,7 @@

it 'returns article URL' do
expect(url).to eq(
'https://www.login.gov/help/verify-your-identity/accepted-state-issued-identification/#test-anchor-url',
'https://www.login.gov/help/verify-your-identity/accepted-identification-documents/#test-anchor-url',
)
end
end
Expand All @@ -213,7 +213,7 @@

context 'with valid article' do
let(:category) { 'verify-your-identity' }
let(:article) { 'accepted-state-issued-identification' }
let(:article) { 'accepted-identification-documents' }

it { expect(result).to eq(true) }

Expand Down