-
Notifications
You must be signed in to change notification settings - Fork 166
LG-13627 Add doc auth result to in_person enrollments #10950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4facca9
add doc_auth_result to in_person_enrollments table
theabrad 1d09846
store doc_auth_result in idv_session
theabrad 3954a15
add doc_auth_result to ipp enrollment
theabrad d6b2cef
add doc_auth_result to analytics events
solipet 3e7c8fd
add doc_auth_result to DocumentCaptureSession
theabrad bfdff3e
doc_auth_result into documentcapturesession part 2
theabrad a1c366f
passing the doc_auth_result via the DocumentCaptureSession model
solipet b77fc91
added test for doc_auth_result in enrollment
theabrad 33dfa6b
api_image_upload_form test for failed doc_auth_response
theabrad 98d8fd7
track analytics for ipp doc_auth_result after finishing ipp
theabrad db89817
add changelog
theabrad c7f4c58
lint
theabrad f6ca12a
fix specs
theabrad 5cd326c
db schema fix
theabrad 406bfc0
allow doc_auth_result to be stored in standard and hybrid flow
theabrad 7cb4d82
small fixup
theabrad 02463a3
revert hybrid user test to what it was before
theabrad 5df01a3
add in_person_proofing_result and doc_auth_result to the analytics event
theabrad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
db/primary_migrate/20240708183211_add_doc_auth_result_to_in_person_enrollments.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| class AddDocAuthResultToInPersonEnrollments < ActiveRecord::Migration[7.1] | ||
| def change | ||
| add_column :in_person_enrollments, :doc_auth_result, :string | ||
| add_column :document_capture_sessions, :last_doc_auth_result, :string | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,9 @@ | |
| zipcode: '12345', | ||
| issuing_country_code: 'USA', | ||
| ), | ||
| extra: { | ||
| doc_auth_result: 'Passed', | ||
| }, | ||
| ) | ||
| end | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it'd be hepful to add in_person_proofing_status and doc_auth_result to user_registration_complete method in analytics_events.rb ?