-
Notifications
You must be signed in to change notification settings - Fork 166
LG-13663: recaptcha sign in failure page #10944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e4fa690
changelog: Upcoming Features, Authentication, Recaptcha Sign in
mdiarra3 66497da
fix spec
mdiarra3 89c9553
add test to ensure user redirected to security check failed
mdiarra3 55ffd5f
Merge remote-tracking branch 'origin/main' into LG-13663-recaptcha-si…
mdiarra3 8d917b0
add additional languges and page
mdiarra3 4ef864c
address comments
mdiarra3 7c41324
lint fix
mdiarra3 0213dac
address comments
mdiarra3 4ff0a31
use c
mdiarra3 9d3e18f
fix failed
mdiarra3 12d6b3c
sign in security check controller spec added
mdiarra3 c62afd4
change spec name
mdiarra3 597546d
use back instead of cancel
mdiarra3 3cae2db
update security check failed spec
mdiarra3 d177f19
Merge remote-tracking branch 'origin/main' into LG-13663-recaptcha-si…
mdiarra3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| class SignInSecurityCheckFailedController < ApplicationController | ||
| def show | ||
| analytics.sign_in_security_check_failed_visited | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <% self.title = t('security_check_failed.title') %> | ||
|
|
||
| <%= render StatusPageComponent.new(status: :warning) do |c| %> | ||
| <% c.with_header { t('security_check_failed.title') } %> | ||
| <p> | ||
| <%= t('security_check_failed.details') %> | ||
| <%= new_tab_link_to( | ||
| t('security_check_failed.learn_more', app_name: APP_NAME), | ||
| help_center_redirect_path( | ||
| category: 'trouble-signing-in', | ||
| article: 'security-check-failed', | ||
|
mdiarra3 marked this conversation as resolved.
|
||
| ), | ||
| ) %> | ||
| </p> | ||
|
|
||
| <ul class="usa-list"> | ||
| <li><%= t('security_check_failed.info_p1', app_name: APP_NAME) %></li> | ||
| <li><%= t('security_check_failed.info_p2_html', piv_cac_url: login_piv_cac_url) %></li> | ||
| <li><%= t('security_check_failed.info_p3') %></li> | ||
| </ul> | ||
|
|
||
| <% c.with_troubleshooting_options do |tc| %> | ||
| <% tc.with_header { t('components.troubleshooting_options.default_heading') } %> | ||
| <% tc.with_option( | ||
| url: contact_redirect_url, | ||
| new_tab: true, | ||
| ).with_content(t('security_check_failed.contact', app_name: APP_NAME)) %> | ||
| <% end %> | ||
| <% end %> | ||
|
|
||
| <%= render 'shared/cancel', link: root_url %> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -1487,6 +1487,13 @@ risc.security_event.errors.typ_error: typ header must be %{expected_typ} | |||||||
| saml_idp.auth.error.title: Error | ||||||||
| saml_idp.shared.saml_post_binding.heading: Submit to continue | ||||||||
| saml_idp.shared.saml_post_binding.no_js: JavaScript seems to be turned off in your browser. Normally this step happens automatically, but because you have JavaScript turned off, please click the submit button to continue signing in or signing out. | ||||||||
| security_check_failed.contact: Contact %{app_name} support | ||||||||
| security_check_failed.details: We don’t recognize the device or browser you’re signing in from. | ||||||||
| security_check_failed.info_p1: 'Use the same device and browser you created your %{app_name} account with.' | ||||||||
| security_check_failed.info_p2_html: Try <a href="%{piv_cac_url}">signing in with your government employee ID</a> if you are a government employee. | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IMO I think it might be a little more reliable to get things through the i18n process to break the link title into its own key
Suggested change
and then update the callsite to be like <li><%= t('security_check_failed.info_p2_html', piv_cac_link_html: link_to(t('security_check_failed.info_p2_link_html'), login_piv_cac_url) %></li> |
||||||||
| security_check_failed.info_p3: Turn off any VPN, ad blockers, and clear your cache. | ||||||||
| security_check_failed.learn_more: Learn more about %{app_name}’s security checks | ||||||||
| security_check_failed.title: Security check failed | ||||||||
| service_providers.errors.generic_sp_name: This agency | ||||||||
| service_providers.errors.inactive.button_text: View my %{app_name} account | ||||||||
| service_providers.errors.inactive.heading: '%{sp_name} no longer uses %{app_name}' | ||||||||
|
|
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
spec/controllers/sign_in_security_check_failed_controller_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| require 'rails_helper' | ||
|
|
||
| RSpec.describe SignInSecurityCheckFailedController do | ||
| let(:user) { build_stubbed(:user, :fully_registered) } | ||
|
|
||
| before do | ||
| stub_sign_in(user) | ||
| end | ||
|
|
||
|
mdiarra3 marked this conversation as resolved.
Outdated
|
||
| it 'renders the show template' do | ||
| stub_analytics | ||
|
|
||
| get :show | ||
|
|
||
| expect(@analytics).to have_logged_event(:sign_in_security_check_failed_visited) | ||
|
|
||
| expect(response).to render_template :show | ||
| end | ||
|
mdiarra3 marked this conversation as resolved.
Outdated
|
||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.