Merged
Conversation
* Update Stylelint configuration to forbid CSS !important changelog: Internal, Linting, Update Stylelint configuration to forbid CSS !important * Remove redundant styles from email stylesheet * Retitle changelog for unreleased changes
…ring IdV (#10867) The `PendingProfileConcern` uses the `PendingProfilePolicy` to check if a user has a pending profile and needs to be redirected to finish proofing. We have code in the `IdvStepConcern` that does the same, but does not factor all of the things that go into that function, such as whether the SP requested a biometric comparison and the pending profile had a biometric comparison. This commit uses the `PendingProfileConcern` in the `IdvStepConcern` to ensure the pending profile logic is consistent. [skip changelog]
changelog: Internal, Dependencies, Update some Ruby dependencies
* Bump @18f/identity-design-system from 9.2.0 to 9.3.0 Bumps [@18f/identity-design-system](https://github.com/18F/identity-design-system) from 9.2.0 to 9.3.0. - [Release notes](https://github.com/18F/identity-design-system/releases) - [Changelog](https://github.com/18F/identity-design-system/blob/main/CHANGELOG.md) - [Commits](18F/identity-design-system@v9.2.0...v9.3.0) --- updated-dependencies: - dependency-name: "@18f/identity-design-system" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Remove "other" alert handling * Remove temporary patch Now patched upstream --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* changelog: User-Facing Improvements, Authentication, Update OTP error message * update for width to be full length for errors * update to remove important
* changelog: User-Facing Improvements, Authentication, Let users know how long they have until they can try to enter password in again * address comments and fix specs * update session controller to not stub method * change to_i * fix spec to ensure they work as intended * change rack spec to what it was originally * remove unused test * change naming scheme
Contributor
|
The diff is a little funky due to the revert, this is a better illustration of the changes: https://github.com/18F/identity-idp/compare/stages/prod..stages/rc-2024-07-03 |
zachmargolis
approved these changes
Jul 3, 2024
mitchellhenke
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal