Merged
Conversation
…ow long they have until they can try to enter password in again
jmdembe
reviewed
Jun 26, 2024
aduth
reviewed
Jun 26, 2024
aduth
reviewed
Jun 27, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I just tried testing this locally and hit an error after being locked out:
aduth
reviewed
Jul 2, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I'm still seeing the error message from my comment at #10873 (review). I think the suggested changes to the spec will surface the same error, to the point of the real code for stubbed methods not working as expected.
aduth
approved these changes
Jul 2, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Nitpick on naming, but LGTM otherwise 👍
| expect(page).to have_content(error_message) | ||
| expect(page).to have_current_path(new_user_session_path) | ||
| end | ||
| locked_at = Time.zone.at(page.get_rack_session['max_bad_passwords_at']) |
Contributor
There was a problem hiding this comment.
Nice that you found a way to get at the session from the feature specs 👍
Contributor
Author
There was a problem hiding this comment.
Yea it was a little annoying because calling that changes page. So I had to call a visit afterwards. railsware/rack_session_access#10 Very weird
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13497
🛠 Summary of changes
Updates the text for Session logout to include how long until user can try again.
👀 Screenshots