Update Stylelint configuration to forbid CSS !important#10904
Merged
Conversation
changelog: Internal, Linting, Update Stylelint configuration to forbid CSS !important
zachmargolis
approved these changes
Jul 2, 2024
mitchellhenke
approved these changes
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
@18f/identity-stylelint-configshared Stylelint configuration to enable thedeclaration-no-importantrule.Related changelog entry, from proposed code:
As part of this, the changes remove one instance of
!importantcurrently used in email stylesheets. These styles appear to be redundant, as they're already applied via upstream Foundation email styles (source).📜 Testing Plan
Verify no regressions in the padding of email templates at small viewports.
Compare: