Skip to content

Update Stylelint configuration to forbid CSS !important#10904

Merged
aduth merged 3 commits intomainfrom
aduth-forbid-css-important
Jul 2, 2024
Merged

Update Stylelint configuration to forbid CSS !important#10904
aduth merged 3 commits intomainfrom
aduth-forbid-css-important

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 2, 2024

🛠 Summary of changes

Updates @18f/identity-stylelint-config shared Stylelint configuration to enable the declaration-no-important rule.

Related changelog entry, from proposed code:

Breaking Changes

[...]

As part of this, the changes remove one instance of !important currently used in email stylesheets. These styles appear to be redundant, as they're already applied via upstream Foundation email styles (source).

📜 Testing Plan

Verify no regressions in the padding of email templates at small viewports.

Compare:

aduth added 2 commits July 2, 2024 11:51
changelog: Internal, Linting, Update Stylelint configuration to forbid CSS !important
@aduth aduth merged commit 2bf02ee into main Jul 2, 2024
@aduth aduth deleted the aduth-forbid-css-important branch July 2, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants