Don't allow letter sends when 2 pieces of fair evidence are required#10886
Merged
Don't allow letter sends when 2 pieces of fair evidence are required#10886
Conversation
jmhooper
changed the title
In #10871 we added a requirement that 2 pieces of fair evidence are required during verification. This is active whenever a SP requests biometric comparison. This commit adds enforcement of that requirement. It uses the `GpoVerifyForm` added in #10844 to disallow sends when that requirement is in place. changelog: User-Facing Improvements, Verify By Mail Flow, The verify by mail flow enforces the 2 pieces of fair evidence requirement which disallows verify by mail when a SP requests an authn context with the requirement.
jmhooper
force-pushed
the
jmhooper-disallow-gpo-during-biometric-proofing
branch
from
be4426e to
ef21aaf
Compare
Contributor
Author
|
I am marking this as WIP. I need to put together some feature specs for this. |
matthinz
reviewed
Jun 28, 2024
n1zyy
approved these changes
Jul 1, 2024
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
I feel like I'm still coming up to speed on some of the VoT stuff and thus maybe not an SME for some of this, but this all looks reasonable to me. The GpoVerifyByMailPolicy changes end up making it all look easy!
| minimum_wait_before_another_usps_letter_in_hours: 24 | ||
| mx_timeout: 3 | ||
| new_device_alert_delay_in_minutes: 5 | ||
| no_verify_by_mail_for_biometric_comparison_enabled: true |
Contributor
There was a problem hiding this comment.
I started to bikeshed the leading "no_" here but then read past comments and decided it's lovely. 😇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10871 we added a requirement that 2 pieces of fair evidence are required during verification. This is active whenever a SP requests biometric comparison. This commit adds enforcement of that requirement. It uses the
GpoVerifyFormadded in #10844 to disallow sends when that requirement is in place.