Don't allow letter sends when 2 pieces of fair evidence are required#10878
Closed
Don't allow letter sends when 2 pieces of fair evidence are required#10878
Conversation
Contributor
There was a problem hiding this comment.
Seems like this is constructed in many separate controllers. Would it make sense to have one policy on a mixin shared by all these controllers? Or just on ApplicationController?
Contributor
Author
There was a problem hiding this comment.
Yeah, when I was putting this together I was thinking that a mixin may make this a little cleaner.
Contributor
Author
There was a problem hiding this comment.
I would imagine we could introduce the policy and delegate send_letter_available? and resend_letter_available? and then call those directly in the controllers.
jmhooper
force-pushed
the
jmhooper-disallow-gpo-during-biometric-proofing
branch
from
563ef23 to
495fbe2
Compare
Contributor
Author
|
I closed this and moved the changes over to #10886 which is where I plan to build out something mergeable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a lot of pending changes out there to make this possible. This commit adds them all together so we can get started on feature tests while we work through getting those merged.