LG-11285: Add helper function to clean up observable properties#10809
Merged
zachmargolis merged 12 commits intoLG-11285-handle-extra-acuant-callbackfrom Jun 13, 2024
Merged
Conversation
…lback' into margolis-observable-property
solipet
approved these changes
Jun 12, 2024
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
Definitely a cleaner approach. Tested with document capture on mobile and did not trigger the TypeError we've been seeing.
solipet
requested changes
Jun 12, 2024
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
Actually just noticed we still need to remove the resetObservableProperty method and call.
app/javascript/packages/document-capture/components/acuant-capture-canvas.jsx
Outdated
Show resolved
Hide resolved
aduth
reviewed
Jun 20, 2024
Contributor
There was a problem hiding this comment.
I'd expect this folder to contain higher-order React components, which this isn't. I might have suggested this be implemented as a hook instead, like useDefinedProperty.
Contributor
Author
There was a problem hiding this comment.
ok! I can clean it up to be a hook, I was just guessing what to call it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative approach to #10762
Switches approaches to cleaning up callbacks in
useEffect()