Merged
Conversation
* Upgrade to Ruby 3.3.1 in CI image changelog: Internal, Continuous Integration, Upgrade to Ruby 3.3.1 * testing * Update dockerfiles/idp_ci.Dockerfile Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * revert CI image SHA * add comment * revert capybara changes --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
changelog: Internal, Authentication Funnel Report, Remove AAL2 lines from Auth Funnel report
* add mobile phone icon * Update translations for how to verify view * Add translations for how to verify button * Added instance var to selectively display content * fix lint issues * specs for conditional logic on how to verify * fix lint errors * fix linter errors * Create how_to_verify presenter for condi rendering * Update specs to look for specific button * fix linter errors * fix lint errors * Clean up unused var, add extra line * changelog: Upcoming Features, Biometrics, Modified UX/Content on How to Verify view conditionally for biometrics * removed extra blank line * remove extra blank line * Add margin above tag * add verify_online_instruction translation back in * Updated Chinese translation * Add period in translation * Delete dup verify_online_instruction in chinese * delete doc_auth and forms folder * restore eng translations * restore translation files * restore translations * Add class to icon
In #10531 we stopped reading from `sp_session[:biometric_comparison_required]`. In that commit we switched to using the `AuthnContextResolver` result to determine if biometric comparison is required. This removes the unread value from `sp_session`. [skip changelog]
* Add job for sending out drop off reports changelog: Internal, Dropoff Report, Make Dropoff Report able to be sent automatically * Updates based on PR review * Email key is plural now
changelog: Internal, Code Quality, Improve readability of view form code
* Add job for sending out drop off reports changelog: Internal, Dropoff Report, Make Dropoff Report able to be sent automatically * Updates based on PR review * Email key is plural now * Change drop off report job to be weekly
* Add job for sending out drop off reports changelog: Internal, Dropoff Report, Make Dropoff Report able to be sent automatically * Updates based on PR review * Email key is plural now * Change drop off report job to be weekly * 1w
aduth
approved these changes
May 16, 2024
Contributor
|
Can you add the changelog to the pull request comment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal
Upcoming Features