Change Drop Off Report job data to be weekly instead of monthly#10630
Merged
Jeremy1026 merged 5 commits intomainfrom May 15, 2024
Merged
Change Drop Off Report job data to be weekly instead of monthly#10630Jeremy1026 merged 5 commits intomainfrom
Jeremy1026 merged 5 commits intomainfrom
Conversation
changelog: Internal, Dropoff Report, Make Dropoff Report able to be sent automatically
h-m-m
approved these changes
May 15, 2024
Contributor
h-m-m
left a comment
h-m-m
left a comment
There was a problem hiding this comment.
I was not able to find anywhere else in the code where we reference this report pulling monthly data
| # Weekly drop of report | ||
| drop_off_report: { | ||
| class: 'Reports::DropOffReport', | ||
| cron: cron_24h, |
Contributor
There was a problem hiding this comment.
Does this mean that the report runs every night to show the past week's worth of data?
Contributor
There was a problem hiding this comment.
I'm wondering about this too..
Contributor
There was a problem hiding this comment.
Hm. Good point. Should this be cron_1w instead? Or is there logic in the report to determine when it actually runs? 🤔
Sgtpluck
reviewed
May 15, 2024
| # Weekly drop of report | ||
| drop_off_report: { | ||
| class: 'Reports::DropOffReport', | ||
| cron: cron_24h, |
Contributor
There was a problem hiding this comment.
Suggested change
| cron: cron_24h, | |
| cron: cron_1w, |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12217
🛠 Summary of changes
Change the job to be weekly instead of monthly based on conversation in slack