Jmax/lg 12267 replace sp session biometric comparison required#10531
Merged
Jmax/lg 12267 replace sp session biometric comparison required#10531
Conversation
And while I'm at it: changelog: Internal,Vector of Trust,Removed use of sp_session[:biometric_comparison_required]
jmax-gsa
force-pushed
the
jmax/LG-12267-replace-sp-session-biometric-comparison-required
branch
from
a598fa8 to
22fdda1
Compare
jmhooper
approved these changes
May 6, 2024
jmax-gsa
deleted the
jmax/LG-12267-replace-sp-session-biometric-comparison-required
branch
jmhooper
added a commit
that referenced
this pull request
May 14, 2024
In #10531 we stopped reading from `sp_session[:biometric_comparison_required]`. In that commit we switched to using the `AuthnContextResolver` result to determine if biometric comparison is required. This removes the unread value from `sp_session`. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
May 14, 2024
In #10531 we stopped reading from `sp_session[:biometric_comparison_required]`. In that commit we switched to using the `AuthnContextResolver` result to determine if biometric comparison is required. This removes the unread value from `sp_session`. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12267
🛠 Summary of changes
Replace all uses of
ServiceProviderSession#biometric_comparison_required?with calls toresolved_authn_context_result.biometric_comparison?📜 Testing Plan
Provide a checklist of steps to confirm the changes.
ServiceProviderSession#biometric_comparison_required?