Skip to content

Change Drop Off Report job data to be weekly instead of monthly #10630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jeremy1026 merged 5 commits into from
May 15, 2024
Merged

Change Drop Off Report job data to be weekly instead of monthly #10630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68d5e9e
Add job for sending out drop off reports
Jeremy1026 Apr 10, 2024
bde049c
Updates based on PR review
Jeremy1026 May 14, 2024
aff6c44
Email key is plural now
Jeremy1026 May 14, 2024
682df45
Change drop off report job to be weekly
Jeremy1026 May 15, 2024
dfd7307
Merge branch 'main' into jcurcio/lg-12217-configure-sending-drop-off-…
Jeremy1026 May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/jobs/reports/drop_off_report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ def configs
def report_maker(issuers)
Reporting::DropOffReport.new(
issuers: issuers,
time_range: report_date.all_month,
slice: 1.month,
time_range: report_date.all_week,
slice: 1.week,
)
end
end
Expand Down
2 changes: 1 addition & 1 deletion config/initializers/job_configurations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@
cron: cron_24h,
args: -> { [Time.zone.yesterday.end_of_day] },
},
# Monthly drop of report
# Weekly drop of report
drop_off_report: {
class: 'Reports::DropOffReport',
cron: cron_24h,
Copy link
Copy Markdown
Contributor

@h-m-m h-m-m May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that the report runs every night to show the past week's worth of data?

Copy link
Copy Markdown
Contributor

@nprimak nprimak May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering about this too..

Copy link
Copy Markdown
Contributor

@mmagsa mmagsa May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Good point. Should this be cron_1w instead? Or is there logic in the report to determine when it actually runs? 🤔

Copy link
Copy Markdown
Contributor

@Sgtpluck Sgtpluck May 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cron: cron_24h,
cron: cron_1w,

Expand Down
2 changes: 1 addition & 1 deletion spec/jobs/reports/drop_off_report_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@

subject.report_date = report_date

expect(subject.report_maker([]).time_range).to eq(report_date.all_month)
expect(subject.report_maker([]).time_range).to eq(report_date.all_week)
end
end
end