LG-13300: Include key_id in valid certificate token#455
Merged
Conversation
zachmargolis
approved these changes
May 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-13300
🛠 Summary of changes
Updates the returned token for a valid certificate to include
key_id, for consistency with invalid certificates' response value, and to enable the IdP logging behavior expected in LG-12946 as of 18F/identity-idp#10512 .📜 Testing Plan
identity-idprunning concurrentlyidentity_pki_disabledis not set totruein your local IdPconfig/application.ymlso that real PKI service is usedmake watch_eventsrunning in a third terminal process withinidentity-idpmake watch_eventsand find the "Multi-Factor Authentication Setup" eventkey_idis a non-nullvalue