Skip to content

LG-10790 Delete Deprecated Residential Address URL#10489

Closed
gina-yamada wants to merge 2 commits intomainfrom
yamada/lg-10790-fsm-resi-addr-url-cleanup
Closed

LG-10790 Delete Deprecated Residential Address URL#10489
gina-yamada wants to merge 2 commits intomainfrom
yamada/lg-10790-fsm-resi-addr-url-cleanup

Conversation

@gina-yamada
Copy link
Contributor

@gina-yamada gina-yamada commented Apr 23, 2024

🎫 Ticket

LG-10790 FSM/Residential Address - Change url - Part 2- Clean Up

🛠 Summary of changes

  • In PR# 10790, the residential address url route was renamed and the/in_person_proofing/address route was deprecated
  • This pull request is just cleaning up the deprecated routes now that the new route was merged into production on 04/23
  • There should be no user facing changes/impacts

📜 Testing Plan

Check 1:

  • Complete in-person proofing up to state id step, pick No, I live at a different address, click Continue
  • Verify that URL ends with /verify/in_person/address
  • Complete form with a different address and submit address form
  • Complete and submit ssn form
  • Verify that address you typed is what appears on the Verify Info page
  • Click Update for section Current residential address on the Verify Info page
  • Verify that URL ends with /verify/in_person/address
  • Submit address form
  • Verify that address you typed is what appears on the Verify Info page
  • Continue through the flow to confirm you get a barcode

Check 2:

  • Complete in-person proofing up to state id step, pick same address as ID on state id form, click Continue
  • Complete and submit ssn form
  • Verify that address you typed is what appears on the Verify Info page
  • Click Update for section Current residential address on the Verify Info page
  • Verify that URL ends with /verify/in_person/address
  • Submit address form
  • Verify that address you typed is what appears on the Verify Info page
  • Continue through the flow to confirm you get a barcode

Check 3:

  • Once on the /verify/in_person/address page, if you manually change the url by typing /verify/in_person_proofing/address in the url, you are not directed anywhere and the url remains /verify/in_person/address

@gina-yamada
Copy link
Contributor Author

How long should I wait before merging this cleanup? The new route was merged into production on 04/23.

@aduth
Copy link
Contributor

aduth commented Apr 23, 2024

How long should I wait before merging this cleanup? The new route was merged into production on 04/23.

The current guidance is 2-4 weeks:

Deploy 3: 2-4 weeks later, check production.log request logs and remove the deprecated route.

https://handbook.login.gov/articles/manage-50-50-state.html#routes

@gina-yamada
Copy link
Contributor Author

https://handbook.login.gov/articles/manage-50-50-state.html#routes

Thanks! In that case- I will close this PR and open a new ticket/PR in 2 weeks.

@gina-yamada
Copy link
Contributor Author

Closing PR as this will need to sit for 2-4 weeks as recommended in the https://handbook.login.gov/articles/manage-50-50-state.html#routes.

Ticket to handle: https://cm-jira.usa.gov/browse/LG-13150

@aduth aduth deleted the yamada/lg-10790-fsm-resi-addr-url-cleanup branch April 23, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants