Skip to content

Use SVG Animation for Yubikey images#10367

Merged
zachmargolis merged 3 commits intoLG-12596-Update-security-key-setupfrom
margolis-svg-animation
Apr 4, 2024
Merged

Use SVG Animation for Yubikey images#10367
zachmargolis merged 3 commits intoLG-12596-Update-security-key-setupfrom
margolis-svg-animation

Conversation

@zachmargolis
Copy link
Contributor

@zachmargolis zachmargolis commented Apr 4, 2024

Prompted by a question on #10323 (comment)

Results

Filesizes (uncompressed)

before (GIF) after (SVG) Δ % reduction
Desktop 125kb 4kb -121kb 96.8%
Mobile 129kb 4kb -125kb 96.9%

Process

@zachmargolis
Copy link
Contributor Author

Testing it locally, it animates! However, it looks like the CSS rounded corners are conflicting with the ones built in to the SVG, will try to remedy

Screen.Recording.2024-04-04.at.12.15.55.PM.mov

@zachmargolis
Copy link
Contributor Author

Testing it locally, it animates! However, it looks like the CSS rounded corners are conflicting with the ones built in to the SVG, will try to remedy

Screen.Recording.2024-04-04.at.12.15.55.PM.mov

Fixed in 91421d1, result:

Screenshot 2024-04-04 at 12 17 33 PM

@jc-gsa
Copy link
Contributor

jc-gsa commented Apr 4, 2024

Looks great, much smoother!

@zachmargolis zachmargolis merged commit cddaf31 into LG-12596-Update-security-key-setup Apr 4, 2024
@zachmargolis zachmargolis deleted the margolis-svg-animation branch April 4, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants