Use SVG Animation for Yubikey images#10367
Merged
zachmargolis merged 3 commits intoLG-12596-Update-security-key-setupfrom Apr 4, 2024
Merged
Use SVG Animation for Yubikey images#10367zachmargolis merged 3 commits intoLG-12596-Update-security-key-setupfrom
zachmargolis merged 3 commits intoLG-12596-Update-security-key-setupfrom
Conversation
Contributor
Author
|
Testing it locally, it animates! However, it looks like the CSS rounded corners are conflicting with the ones built in to the SVG, will try to remedy Screen.Recording.2024-04-04.at.12.15.55.PM.mov |
Contributor
Author
Fixed in 91421d1, result:
|
Contributor
|
Looks great, much smoother! |
jc-gsa
approved these changes
Apr 4, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Prompted by a question on #10323 (comment)
Results
Filesizes (uncompressed)
Process
<animate>and<animateTransform>to replace the<svg-animate>andanim:attributes that the Figma plugin used