Skip to content

Use SVG Animation for Yubikey images #10367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 3 commits into from
Apr 4, 2024
Merged

Use SVG Animation for Yubikey images #10367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09d6569
Swap GIFs for animated SVGs
zachmargolis Apr 4, 2024
bb9d69d
Optimize SVGs
zachmargolis Apr 4, 2024
91421d1
Remove duplicative rounded corners
zachmargolis Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed app/assets/images/mfa-options/security_key.gif
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions app/assets/images/mfa-options/security_key.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed app/assets/images/mfa-options/security_key_mobile.gif
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions app/assets/images/mfa-options/security_key_mobile.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions app/views/users/webauthn_setup/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@
<% end %>
<%= c.with_item(heading: t('forms.webauthn_setup.step_2')) do %>
<% if mobile? %>
<%= image_tag asset_url('mfa-options/security_key_mobile.gif'), width: 420, height: 193, class: 'height-auto rounded-xl', alt: t('forms.webauthn_setup.step_2_image_mobile_alt') %>
<%= image_tag asset_url('mfa-options/security_key_mobile.svg'), width: 420, height: 193, class: 'height-auto', alt: t('forms.webauthn_setup.step_2_image_mobile_alt'), role: 'img' %>
<% else %>
<%= image_tag asset_url('mfa-options/security_key.gif'), width: 420, height: 193, class: 'height-auto rounded-xl', alt: t('forms.webauthn_setup.step_2_image_alt') %>
<%= image_tag asset_url('mfa-options/security_key.svg'), width: 420, height: 193, class: 'height-auto', alt: t('forms.webauthn_setup.step_2_image_alt'), role: 'img' %>
<% end %>
<% end %>
<%= c.with_item(heading: t('forms.webauthn_setup.step_3')) do %>
Expand Down
4 changes: 2 additions & 2 deletions spec/views/users/webauthn_setup/new.html.erb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
it 'displays the security key image' do
render

expect(rendered).to match(/src=".*security_key-.*\.gif"/)
expect(rendered).to match(/src=".*security_key-.*\.svg"/)
end

context 'when on a mobile device' do
Expand All @@ -151,7 +151,7 @@
it 'displays the mobile security key image' do
render

expect(rendered).to match(/src=".*security_key_mobile-.*\.gif"/)
expect(rendered).to match(/src=".*security_key_mobile-.*\.svg"/)
end
end
end
Expand Down