LG-12596: Update security key setup page#10323
Conversation
changelog: User-Facing Improvements, Authentication, Update security key setup form
jc-gsa
changed the title
jc-gsa
changed the title
jc-gsa
force-pushed
the
LG-12596-Update-security-key-setup
branch
from
7112e0b to
08a8657
Compare
jc-gsa
force-pushed
the
LG-12596-Update-security-key-setup
branch
from
08a8657 to
202f4ff
Compare
| <% end %> | ||
| <%= c.with_item(heading: t('forms.webauthn_setup.step_2')) do %> | ||
| <% if @mobile %> | ||
| <%= image_tag asset_url('mfa-options/security_key_mobile.gif'), class: 'rounded-xl', alt: t('forms.webauthn_setup.step_2_image_mobile_alt') %> |
There was a problem hiding this comment.
Open to different CSS classes for this style.
jc-gsa
left a comment
jc-gsa
left a comment
There was a problem hiding this comment.
Double checking wether or not we want to remove the remember device checkbox. Designs do not seem to have it, yet I believe other pages like TOTP setup do.
That's a good call-out, can you check to confirm with the UX team? Personally I would prefer that we have it, since remembered device is a big usability boost, and I wouldn't feel comfortable defaulting to remember without the user's awareness. |
jc-gsa
force-pushed
the
LG-12596-Update-security-key-setup
branch
from
9358beb to
b723c56
Compare
…dentity-idp into LG-12596-Update-security-key-setup
jc-gsa
force-pushed
the
LG-12596-Update-security-key-setup
branch
from
8c7df36 to
851f88d
Compare
jc-gsa
force-pushed
the
LG-12596-Update-security-key-setup
branch
from
7a5e979 to
5506917
Compare
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Couple minor comments about test coverage, but tested and LGTM otherwise 👍
Use SVG Animation for Yubikey images
5 participants
🎫 Ticket
LG-12596
🛠 Summary of changes
Updates the security key setup page found at
/webauthn_setup.