Skip to content

Revert Change that Didnt Fix Blackscreen #10332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charleyf merged 4 commits into from
Apr 23, 2024
Merged

Revert Change that Didnt Fix Blackscreen #10332

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a55782d
Clear out message and show "Photo captured" when it succeeds
charleyf Mar 28, 2024
4652a92
changelog: User-Facing Improvements, Selfie, Change hint text update …
charleyf Mar 28, 2024
2a673e6
Revert changes
charleyf Apr 11, 2024
8b127d5
Merge branch 'main' into charley/add-back-hint-text
charleyf Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/javascript/packages/document-capture/components/acuant-selfie-camera.tsx
View file
Open in desktop
Copy link
Copy Markdown
Contributor Author

@charleyf charleyf Apr 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what does following meant? @charleyf

It also adds an announcement (via hint text) when the selfie is captured.

@dawei-nava This is a leftover sentence that no longer reflects what I'm doing in the PR. Removed! Thanks

Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,12 @@ function AcuantSelfieCamera({
},
onOpened: () => {
// Camera has opened
onImageCaptureFeedback('');
onImageCaptureOpen();
},
onClosed: () => {
// Camera has closed
onImageCaptureFeedback('');
onImageCaptureClose();
},
onError: (error) => {
Expand Down