LG-12268: Use Department of State translations for Face Match Fail#10298
Merged
eileen-nava merged 3 commits intomainfrom Mar 25, 2024
Merged
LG-12268: Use Department of State translations for Face Match Fail#10298eileen-nava merged 3 commits intomainfrom
eileen-nava merged 3 commits intomainfrom
Conversation
eileen-nava
requested review from
a team,
charleyf and
kellular
and removed request for
a team
eileen-nava
commented
Mar 25, 2024
| message = strip_tags(t('errors.doc_auth.selfie_fail_heading')) | ||
| expect(page).to have_content(message) | ||
| detail_message = strip_tags(t('doc_auth.errors.alerts.selfie_poor_quality')) | ||
| detail_message = strip_tags(t('doc_auth.errors.alerts.selfie_not_live')) |
Contributor
Author
There was a problem hiding this comment.
Before updating translations, the text for 'doc_auth.errors.alerts.selfie_poor_quality' and 'doc_auth.errors.alerts.selfie_not_live' were the same. Since they are no longer the same, I had to update this spec.
kellular
approved these changes
Mar 25, 2024
kellular
left a comment
kellular
left a comment
There was a problem hiding this comment.
Double-checked the updates with the translations I got back DOS. This PR looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12268: Implement Department of State translation for in-line error message for FaceMatchResult: Fail
🛠 Summary of changes
📜 Testing Plan
To test on desktop...
application.yml, set the below variables/test/oidc/logintest_selfie_with_face_match_fail.ymlin all three (front/back/selfie) fields👀 Screenshots
English:
Spanish:
French: