Skip to content

LG-12080: Error Messages for Facematch Fail#10042

Merged
charleyf merged 34 commits intomainfrom
charley/lg-12080-error-messages-for-facematch-fail
Feb 22, 2024
Merged

LG-12080: Error Messages for Facematch Fail#10042
charleyf merged 34 commits intomainfrom
charley/lg-12080-error-messages-for-facematch-fail

Conversation

@charleyf
Copy link
Contributor

@charleyf charleyf commented Feb 6, 2024

🎫 Ticket

https://cm-jira.usa.gov/browse/LG-12080

🛠 Summary of changes

This ticket adds the error messaging for when:

  • The selfie liveness and quality pass.
  • The selfie does not match the image on the ID.

📜 Testing Plan

Provide a checklist of steps to confirm the changes. YAML files are here.

  • Click a magic link like this one to get to the IDP app with selfie enabled. Alternately, use the SAML/OIDC test apps.
  • Create an account, and get to the front/back/selfie upload page.
  • Upload the test_selfie_with_face_match_fail.yml file in all three (front/back/selfie) fields.
  • "Submit" the page and look at the next page. It should match the figma and screenshots (below).
  • Click "Try again online" and note that the next screen matches the figma and screenshots.
  • Repeat these steps with the test_selfie_with_no_liveness.yml file. You should see different results, but they should be the same on main and this branch.

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Failure page after changes failure_page_from_figma
Retry page after changes try_again_from_figma

@charleyf charleyf marked this pull request as draft February 6, 2024 16:15
@charleyf charleyf changed the title Charley/lg 12080 error messages for facematch fail LG-12080: Error Messages for Facematch Fail Feb 6, 2024
@charleyf charleyf mentioned this pull request Feb 13, 2024
12 tasks
@charleyf charleyf marked this pull request as ready for review February 15, 2024 15:29
Copy link
Contributor

@eileen-nava eileen-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.

Copy link
Contributor

@eileen-nava eileen-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@@ -16,6 +16,7 @@ import {
import type { ReviewIssuesStepValue } from './review-issues-step';

interface DocumentCaptureReviewIssuesProps extends FormStepComponentProps<ReviewIssuesStepValue> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with the no liveness yml and it worked! See below for screenshots.

Failure Page:

NoLivenessFailurePage

Failure Page (scrolled down to shown the IPP prompt):

NoLivenessFailurePageShowsIPP

Retry Page:

NoLivenessRetryPage

@charleyf charleyf merged commit 2b96187 into main Feb 22, 2024
@charleyf charleyf deleted the charley/lg-12080-error-messages-for-facematch-fail branch February 22, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants