Skip to content

LG-12268: Use Department of State translations for Face Match Fail #10298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eileen-nava merged 3 commits into from
Mar 25, 2024
Merged

LG-12268: Use Department of State translations for Face Match Fail #10298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e51fe7c
Update selfie face match fail headings & body copy
eileen-nava Mar 25, 2024
cb926ad
Changelog: User-Facing Improvements, DocAuth, update selfie face matc…
eileen-nava Mar 25, 2024
4ed6ccc
normalize yaml file and fix spec drift
eileen-nava Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/locales/doc_auth/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ en:
the picture. Try taking new pictures.
issue_date_checks: We couldn’t read the issue date on your ID. Try taking new pictures.
ref_control_number_check: We couldn’t read the control number barcode. Try taking new pictures.
selfie_not_live: 'Try taking a photo of yourself again. Make sure your whole
face is clear and visible in the photo.'
selfie_not_live: 'Try taking your photos again. Make sure all of your photos are
clear and in focus.'
selfie_poor_quality: 'Try taking a photo of yourself again. Make sure your whole
face is clear and visible in the photo.'
sex_check: We couldn’t read the sex on your ID. Try taking new pictures.
Expand Down
4 changes: 2 additions & 2 deletions config/locales/doc_auth/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ es:
identidad. Intente tomar nuevas fotos.
ref_control_number_check: No pudimos leer el código de barras del número de
control. Intente tomar nuevas fotografías.
selfie_not_live: 'Intente tomar de nuevo una foto de usted. Asegúrese de que su
rostro se vea claramente en la foto.'
selfie_not_live: 'Intente tomar de nuevo sus fotos. Asegúrese de que sus fotos
estén claras y enfocadas.'
selfie_poor_quality: 'Intente tomar de nuevo una foto de usted. Asegúrese de que
su rostro se vea claramente en la foto.'
sex_check: No pudimos leer el sexo en su documento de identidad. Intente tomar
Expand Down
5 changes: 2 additions & 3 deletions config/locales/doc_auth/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,8 @@ fr:
d’identité. Essayez de prendre de nouvelles photos.
ref_control_number_check: Nous n’avons pas pu lire le code-barres du numéro de
contrôle. Essayez de prendre de nouvelles photos.
selfie_not_live: 'Essayez de prendre une nouvelle photo de vous-même.
Assurez-vous que l’ensemble de votre visage soit clair et visible sur
la photo.'
selfie_not_live: 'Essayez de prendre de nouvelles photos de vous-même. Veillez à
ce que toutes vos photos soient claires et nettes.'
selfie_poor_quality: 'Essayez de prendre une nouvelle photo de vous-même.
Assurez-vous que l’ensemble de votre visage soit clair et visible sur
la photo.'
Expand Down
2 changes: 1 addition & 1 deletion config/locales/errors/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ es:
rate_limited_text_html: 'Por su seguridad, limitamos el número de veces que
puede intentar verificar un documento en línea. <strong>Inténtelo de
nuevo en %{timeout}.</strong>'
selfie_fail_heading: No pudimos cotejar tu foto con tu identificación
selfie_fail_heading: No hemos podido cotejar su foto con su identificación.
selfie_not_live_or_poor_quality_heading: No pudimos verificar su foto
send_link_limited: Ha intentado demasiadas veces, por favor, inténtelo de nuevo
en %{timeout}. También puede retroceder y elegir utilizar su computadora
Expand Down
4 changes: 2 additions & 2 deletions config/locales/errors/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ fr:
rate_limited_text_html: 'Pour votre sécurité, nous limitons le nombre de fois où
vous pouvez tenter de vérifier un document en ligne. <strong>Veuillez
réessayer dans %{timeout}.</strong>'
selfie_fail_heading: Nous n’avons pas pu faire correspondre votre photo à votre
pièce d’identité
selfie_fail_heading: Nous n’avons pas pu faire correspondre votre photo à celle
figurant sur votre pièce d’identité.
selfie_not_live_or_poor_quality_heading: Nous n’avons pas pu vérifier votre photo
send_link_limited: Vous avez essayé trop de fois, veuillez réessayer dans
%{timeout}. Vous pouvez également revenir en arrière et choisir
Expand Down
2 changes: 1 addition & 1 deletion spec/features/idv/doc_auth/document_capture_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@
submit_images
message = strip_tags(t('errors.doc_auth.selfie_fail_heading'))
expect(page).to have_content(message)
detail_message = strip_tags(t('doc_auth.errors.alerts.selfie_poor_quality'))
detail_message = strip_tags(t('doc_auth.errors.alerts.selfie_not_live'))
Copy link
Copy Markdown
Contributor Author

@eileen-nava eileen-nava Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before updating translations, the text for 'doc_auth.errors.alerts.selfie_poor_quality' and 'doc_auth.errors.alerts.selfie_not_live' were the same. Since they are no longer the same, I had to update this spec.

security_message = strip_tags(
t(
'idv.warning.attempts_html',
Expand Down