-
Notifications
You must be signed in to change notification settings - Fork 166
Fix Network Error in Dev by Adding missing selfie analytics event #10244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
be83824
17ceeeb
b96b033
3e0cf82
255a296
d0193a9
1060dd3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2952,6 +2952,37 @@ def idv_selfie_image_added( | |
| end | ||
| # rubocop:enable Naming/VariableName,Naming/MethodParameterName | ||
|
|
||
| # rubocop:disable Naming/VariableName,Naming/MethodParameterName, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For new analytics events, I'd wonder if it's worth trying to address some of what's being identified in these linters, i.e. naming the event properties with snake case. I suspect it might be made difficult by multiple events sharing the same common payload, but it seems like we will want to address that at some point anyways. |
||
| # @param [Boolean] acuant_sdk_upgrade_a_b_testing_enabled | ||
| # @param [String] acuant_version | ||
| # @param [String] flow_path whether the user is in the hybrid or standard flow | ||
| # @param [Boolean] isDrop | ||
| # @param [String] source | ||
| # @param [String] use_alternate_sdk | ||
| # @param [Boolean] liveness_checking_required | ||
| def idv_selfie_image_clicked( | ||
| acuant_sdk_upgrade_a_b_testing_enabled:, | ||
| acuant_version:, | ||
| flow_path:, | ||
| isDrop:, | ||
| source:, | ||
| use_alternate_sdk:, | ||
| liveness_checking_required: nil, | ||
| **_extra | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
👍 I'd hope we could add all of the properties here we're expecting to be logged. |
||
| ) | ||
| track_event( | ||
| :idv_selfie_image_clicked, | ||
| acuant_sdk_upgrade_a_b_testing_enabled: acuant_sdk_upgrade_a_b_testing_enabled, | ||
| acuant_version: acuant_version, | ||
| flow_path: flow_path, | ||
| isDrop: isDrop, | ||
| source: source, | ||
| use_alternate_sdk: use_alternate_sdk, | ||
| liveness_checking_required: liveness_checking_required, | ||
| ) | ||
| end | ||
| # rubocop:enable Naming/VariableName,Naming/MethodParameterName | ||
|
|
||
| # Tracks when the user visits one of the the session error pages. | ||
| # @param [String] type | ||
| # @param [Integer,nil] submit_attempts_remaining (previously called "attempts_remaining") | ||
|
charleyf marked this conversation as resolved.
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.