Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/controllers/frontend_log_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ class FrontendLogController < ApplicationController
'IdV: personal key acknowledgment toggled' => :idv_personal_key_acknowledgment_toggled,
'IdV: prepare submitted' => :idv_in_person_prepare_submitted,
'IdV: prepare visited' => :idv_in_person_prepare_visited,
'IdV: selfie image clicked' => :idv_selfie_image_clicked,
Comment thread
charleyf marked this conversation as resolved.
'IdV: switch_back submitted' => :idv_in_person_switch_back_submitted,
'IdV: switch_back visited' => :idv_in_person_switch_back_visited,
'IdV: user clicked sp link on ready to verify page' => :idv_in_person_ready_to_verify_sp_link_clicked,
Expand Down
31 changes: 31 additions & 0 deletions app/services/analytics_events.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2952,6 +2952,37 @@ def idv_selfie_image_added(
end
# rubocop:enable Naming/VariableName,Naming/MethodParameterName

# rubocop:disable Naming/VariableName,Naming/MethodParameterName,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For new analytics events, I'd wonder if it's worth trying to address some of what's being identified in these linters, i.e. naming the event properties with snake case. I suspect it might be made difficult by multiple events sharing the same common payload, but it seems like we will want to address that at some point anyways.

# @param [Boolean] acuant_sdk_upgrade_a_b_testing_enabled
# @param [String] acuant_version
# @param [String] flow_path whether the user is in the hybrid or standard flow
# @param [Boolean] isDrop
# @param [String] source
# @param [String] use_alternate_sdk
# @param [Boolean] liveness_checking_required
def idv_selfie_image_clicked(
acuant_sdk_upgrade_a_b_testing_enabled:,
acuant_version:,
flow_path:,
isDrop:,
source:,
use_alternate_sdk:,
liveness_checking_required: nil,
**_extra
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is captureAttempts easy to add in?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is captureAttempts easy to add in?

👍 I'd hope we could add all of the properties here we're expecting to be logged.

)
track_event(
:idv_selfie_image_clicked,
acuant_sdk_upgrade_a_b_testing_enabled: acuant_sdk_upgrade_a_b_testing_enabled,
acuant_version: acuant_version,
flow_path: flow_path,
isDrop: isDrop,
source: source,
use_alternate_sdk: use_alternate_sdk,
liveness_checking_required: liveness_checking_required,
)
end
# rubocop:enable Naming/VariableName,Naming/MethodParameterName

# Tracks when the user visits one of the the session error pages.
# @param [String] type
# @param [Integer,nil] submit_attempts_remaining (previously called "attempts_remaining")
Comment thread
charleyf marked this conversation as resolved.
Expand Down