Skip to content

Clean PIV session detail after deletion (2) #10238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Mar 18, 2024
Merged

Clean PIV session detail after deletion (2) #10238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/controllers/users/piv_cac_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module Users
class PivCacController < ApplicationController
include ReauthenticationRequiredConcern
include PivCacConcern

before_action :confirm_two_factor_authenticated
before_action :confirm_recently_authenticated_2fa
Expand Down Expand Up @@ -33,6 +34,7 @@ def destroy
create_user_event(:piv_cac_disabled)
revoke_remember_device(current_user)
deliver_push_notification
clear_piv_cac_information

flash[:success] = presenter.delete_success_alert_text
redirect_to account_path
Expand Down
6 changes: 6 additions & 0 deletions spec/controllers/users/piv_cac_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,12 @@
expect(flash[:success]).to eq(presenter.delete_success_alert_text)
end

it 'removes the piv/cac information from the user session' do
controller.user_session[:decrypted_x509] = {}
response
expect(controller.user_session[:decrypted_x509]).to be_nil
end

it 'logs the submission attempt' do
response

Expand Down