Skip to content

Stop writing to sp_session[:ialmax] #10128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 1 commit into from
Feb 23, 2024
Merged

Stop writing to sp_session[:ialmax] #10128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions app/services/store_sp_metadata_in_session.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ def ial2_value
parsed_vot&.identity_proofing?
end

def ialmax_value
parsed_vot&.ialmax?
end

def aal_level_requested_value
return nil unless parsed_vot

Expand Down Expand Up @@ -71,7 +67,6 @@ def update_session
request_id: sp_request.uuid,
requested_attributes: sp_request.requested_attributes,
ial2: ial2_value,
ialmax: ialmax_value,
aal_level_requested: aal_level_requested_value,
piv_cac_requested: piv_cac_requested_value,
phishing_resistant_requested: phishing_resistant_value,
Expand Down
1 change: 0 additions & 1 deletion spec/controllers/openid_connect/authorization_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,7 +1083,6 @@
piv_cac_requested: false,
phishing_resistant_requested: false,
ial2: false,
ialmax: false,
issuer: 'urn:gov:gsa:openidconnect:test',
request_id: sp_request_id,
request_url: request.original_url,
Expand Down
2 changes: 0 additions & 2 deletions spec/controllers/saml_idp_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1199,7 +1199,6 @@ def name_id_version(format_urn)
acr_values: acr_values,
phishing_resistant_requested: false,
ial2: false,
ialmax: false,
request_url: @stored_request_url.gsub('authpost', 'auth'),
request_id: sp_request_id,
requested_attributes: ['email'],
Expand Down Expand Up @@ -1238,7 +1237,6 @@ def name_id_version(format_urn)
piv_cac_requested: false,
phishing_resistant_requested: false,
ial2: false,
ialmax: false,
request_url: @saml_request.request.original_url.gsub('authpost', 'auth'),
request_id: sp_request_id,
requested_attributes: ['email'],
Expand Down
13 changes: 0 additions & 13 deletions spec/services/store_sp_metadata_in_session_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
piv_cac_requested: false,
phishing_resistant_requested: false,
ial2: false,
ialmax: false,
request_url: request_url,
request_id: request_id,
requested_attributes: requested_attributes,
Expand All @@ -76,7 +75,6 @@
piv_cac_requested: false,
phishing_resistant_requested: true,
ial2: true,
ialmax: false,
request_url: request_url,
request_id: request_id,
requested_attributes: requested_attributes,
Expand All @@ -101,7 +99,6 @@
piv_cac_requested: false,
phishing_resistant_requested: true,
ial2: true,
ialmax: false,
request_url: request_url,
request_id: request_id,
requested_attributes: requested_attributes,
Expand All @@ -128,7 +125,6 @@
piv_cac_requested: false,
phishing_resistant_requested: true,
ial2: true,
ialmax: false,
request_url: request_url,
request_id: request_id,
requested_attributes: requested_attributes,
Expand All @@ -151,7 +147,6 @@
piv_cac_requested: false,
phishing_resistant_requested: false,
ial2: false,
ialmax: false,
request_url: request_url,
request_id: request_id,
requested_attributes: requested_attributes,
Expand All @@ -175,7 +170,6 @@
piv_cac_requested: false,
phishing_resistant_requested: false,
ial2: true,
ialmax: false,
request_url: request_url,
request_id: request_id,
requested_attributes: requested_attributes,
Expand All @@ -199,7 +193,6 @@
piv_cac_requested: false,
phishing_resistant_requested: false,
ial2: true,
ialmax: false,
request_url: request_url,
request_id: request_id,
requested_attributes: requested_attributes,
Expand All @@ -222,7 +215,6 @@
piv_cac_requested: false,
phishing_resistant_requested: false,
ial2: true,
ialmax: false,
request_url: request_url,
request_id: request_id,
requested_attributes: requested_attributes,
Expand All @@ -245,7 +237,6 @@
piv_cac_requested: false,
phishing_resistant_requested: true,
ial2: true,
ialmax: false,
request_url: request_url,
request_id: request_id,
requested_attributes: requested_attributes,
Expand All @@ -268,7 +259,6 @@
piv_cac_requested: false,
phishing_resistant_requested: true,
ial2: true,
ialmax: false,
request_url: request_url,
request_id: request_id,
requested_attributes: requested_attributes,
Expand All @@ -291,7 +281,6 @@
piv_cac_requested: true,
phishing_resistant_requested: false,
ial2: true,
ialmax: false,
request_url: request_url,
request_id: request_id,
requested_attributes: requested_attributes,
Expand All @@ -314,7 +303,6 @@
piv_cac_requested: true,
phishing_resistant_requested: false,
ial2: true,
ialmax: false,
request_url: request_url,
request_id: request_id,
requested_attributes: requested_attributes,
Expand All @@ -337,7 +325,6 @@
piv_cac_requested: false,
phishing_resistant_requested: false,
ial2: true,
ialmax: false,
request_url: request_url,
request_id: request_id,
requested_attributes: requested_attributes,
Expand Down