Conversation
amirbey
approved these changes
Feb 20, 2024
f65dcc1 to
94610e5
Compare
a38ba8b to
80ee772
Compare
This reverts commit ca3c16c.
changelog: Bug Fixes, Content-Security Policy, Fix conflict with style-src nonce for unsafe inline styles
80ee772 to
8f2b776
Compare
Contributor
Author
|
I'll be planning to test this in deployed environments as well after merge, especially since Threatmetrix is difficult to test locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes an issue where
style-srcnonce being added to default content security policy conflicts with instances where unsafe inline stylesheets are expected to be allowed. The presence of the nonce causes inline styles to only work where the nonce is assigned. Removing the nonce allows inline styles in exempted overrides regardless of the presence of the nonce.This is the fix alternative for #10113, expected to be included with the un-revert.Edit: This reverts #10113, effectively restoring the changes from #10065 and #10098 with the fix described above.📜 Testing Plan
Verify regression tests pass:
Verify that Acuant SDK loads successfully:
Verify no regressions in behavior of Threatmetrix: Must be done in deployed environment.