Merged
Conversation
The commit that was un-reverted here was problematic because of a `NoMethodError` when calling `empty?` on `nil` here:
```ruby
validates :acr_values, presence: true, if: ->(form) { form.vtr.empty? }
```
This commit replaces `#empty?` with `#blank?` which will work on nil. Additionally the `#parse_vtr` method was modified to consistently return `nil` if either a `vtr` param is not provided or the `vtr` param is not enabled.
Tests were added to cover this case.
[skip changelog]
* create resolved_authn_context_result in ApplicationController added a method in ApplicationController to get the resolved authn context. We pass in acr_values and vtr values to determine what the resolved context is. * add spec for #resolved_authn_context_result * add changelog changelog: Internal, IdV, Add method in application_controller to get resolved authn context
* fix pinpoint urls to enable make update_pinpoint_supported_countries * changelog: Internal, DocAuth, update pinpoint sms and voice urls to fix make lint_country_dialing_codes
changelog: Internal, OpenID Connect, Add support for configuring OIDC redirect by service provider
changelog: Internal, Logging, Include email_address_id when logging that an email was sent
…lt (#10035) * remove selfie_success from document_capture_session_result * changelog: Internal, DocAuth, remove selfie_success field from DocumentCaptureSessionResult
* convert submission-status component to typescript [skip changelog] --------- Co-authored-by: Brittany Greaner <brittany.greaner@gsa.gov> Co-authored-by: Charles Ferguson <charles.ferguson@gsa.gov>
* LG-12039: use new fields to define success. changelog: Internal, Doc Auth, Use available new fields for success decision * LG-12039: doc_auth_access should it mean overall success? * LG-12039: pull in changes. * LG-12039: pull in changes. * LG-12039: it's questionable to use concern to reduce code complexity. More appropriate to user helper module. * LG-12039: doc_auth_success already checked attention_with_barcode. * LG-12039: refactor, make it more explicit for status check with both old and new approach. * LG-12039: change based on comments. * LG-12039: removing the props.
* Log sign-in flow for SP redirect analytics event changelog: Internal, Analytics, Add analytics differentiating sign-in flow for completed sign-in * Document nil-able sign_in_flow parameter * Update additional SAML controller specs
* Add sideEffects to all packages * Enforce sideEffects for all packages changelog: Internal, Performance, Reduce size of JavaScript by removing unreachable code * Mark sideEffects in rails-i18n-webpack-plugin specs * Add guidance for missing required fields * Improve messaging for custom elements sideEffects validation * Update documentation references for sideEffects
changelog: Internal, Document Authentication, remove selfie_check_performed field from DocumentCaptureSessionResult
* LG-12300 Exclude Deleted Users from the Reuse Report changelog: Internal, Reporting, Exclude deleted users from Reuse Rate Report
…ivation (#10039) * Add analytics for password verification after profile reactivation Log visits and submissions of the verify password form we display after the user reactivates their profile. changelog: Internal, Identity verification, Add analytics for password verification on profile reactivation. * Update verify_password_controller.rb
* update gitlab ci to track deployments for dora metrics
…0040) * LG-12070: Maintain incoming request for concurrent session logout changelog: Bug Fixes, Concurrent Session, Maintain authentication request when enforcing concurrent session limit * Add comment clarifying ordering See: #10040 (comment)
changelog: Internal, Automated Testing, Improve accuracy of linting checks for React components
mitchellhenke
requested review from
ThatSpaceGuy,
aduth,
amirbey,
eileen-nava,
jmhooper,
matthinz and
theabrad
mdiarra3
approved these changes
Feb 8, 2024
eileen-nava
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Internal